build/config/BUILDCONFIG.gn - Issue 1183633003: cross gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 1183633003: cross gn Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly smaller diff Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 4f3a223c32d23ab7b79007add5081deac14bdf7e..df92a43cc2ab083cb40ac1114750f7b0e10c0635 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -225,7 +225,11 @@ if (target_os == "android") {

_default_toolchain = host_toolchain

} else if (target_os == "win") {

# On Windows we use the same toolchain for host and target by default.

- assert(target_os == host_os, "Win cross-compiles only work on win hosts.")

+ #assert(target_os == host_os, "Win cross-compiles only work on win hosts.")

+ # TODO(thakis): Getting this working requires definiting a clang_x86 toolchain

+ # on mac.

+ assert(host_os != "mac" || target_cpu != "x86",

+ "Doing 32-bit Windows builds on Mac does not yet work, target 64-bit")

if (is_clang) {

_default_toolchain = "//build/toolchain/win:clang_$target_cpu"

} else {

« no previous file with comments | « base/trace_event/trace_log.cc ('k') | build/config/win/manifest.gni » ('j') | no next file with comments »