Sync Windows build flags between GYP and GN

Sync Windows build flags between GYP and GN

In GN, turn on omtimize:max for base targets on all platforms, not just Android (matches GYP).

In GN, don't duplicate /Os twice, make standard optimize = /O1 (matches GYP). Don't specify redundant optimization flags that are included as part of /O1 or /O2 (doesn't match GYP flag-wise, but should match functionality-wise).

In GN, add a min Windows version of XP to x86 architecture binaries (matches GYP).

In GYP, remove /GT ("EnableFiberSafeOptimizations"). This flag is super old (pre-dates GYP) and was likely turned on because it has the word "optimization" in it. It was only specified in official builds. However, according to the docs, this is making optimizations fiber safe (i.e. slower, by not caching the TLS pointer), rather than enabling optimizations for fibers. We don't use fibers so this flag is unnecessary and may be making TLS access slightly slower.

Committed: https://crrev.com/67021f4d70fe838a5d78133bc6d5b305dfd70d72
Cr-Commit-Position: refs/heads/master@{#334742}

[brettw, 2015-06-16 19:47:34]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2015-06-16 19:48:28]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-16 19:50:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183613006/1

[commit-bot: I haz the power, 2015-06-16 19:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 19:59:24]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[brettw, 2015-06-16 20:06:53]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[scottmg, 2015-06-16 20:07:48]

lgtm

https://codereview.chromium.org/1183613006/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1183613006/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1099: "/GF",  # Enable string pooling.
looks like this is on by default for O1 and O2 too too so could probably drop
here, but also fine if you want to kepe it for consistency (I might keep /Os in
that case then too)

[commit-bot: I haz the power, 2015-06-16 20:08:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183613006/20001

[commit-bot: I haz the power, 2015-06-16 20:20:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 20:20:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-06-16 21:02:29]

https://codereview.chromium.org/1183613006/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1183613006/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1099: "/GF",  # Enable string pooling.
On 2015/06/16 20:07:48, scottmg wrote:
> looks like this is on by default for O1 and O2 too too so could probably drop
> here, but also fine if you want to kepe it for consistency (I might keep /Os
in
> that case then too)

I'll remove it.

[brettw, 2015-06-16 21:06:40]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-06-16 21:06:40]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1183613006/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-06-16 21:07:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183613006/60001

[commit-bot: I haz the power, 2015-06-16 23:20:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-16 23:21:19]

Patchset 4 (id:??) landed as
https://crrev.com/67021f4d70fe838a5d78133bc6d5b305dfd70d72
Cr-Commit-Position: refs/heads/master@{#334742}

[phoglund_chromium, 2015-06-17 06:53:02]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1185963004/ by phoglund@chromium.org.

The reason for reverting is: Speculative revert for Linux GN clobber compile
failure:

FAILED: python ../../remoting/webapp/build-webapp.py ...
Traceback (most recent call last):
  File "../../remoting/webapp/build-webapp.py", line 487, in <module>
    sys.exit(main())
  File "../../remoting/webapp/build-webapp.py", line 483, in main
    return buildWebApp(**vars(args))
  File "../../remoting/webapp/build-webapp.py", line 257, in buildWebApp
    + buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Release: 
ninja: build stopped: subcommand failed..