Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: ui/views/controls/slide_out_view.h

Issue 11836003: Allow message center and related bubbles to render on Windows. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove ifdefs. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/slide_out_view.h
diff --git a/ui/views/controls/slide_out_view.h b/ui/views/controls/slide_out_view.h
index 4d36dc418dacb965433ad4bcbaeab2fa00988afe..10cdb6810b10eeecb5a88dfd0ed08ebcd1100977 100644
--- a/ui/views/controls/slide_out_view.h
+++ b/ui/views/controls/slide_out_view.h
@@ -15,6 +15,19 @@ namespace views {
class VIEWS_EXPORT SlideOutView : public views::View,
public ui::ImplicitAnimationObserver {
public:
+ enum SlideDirection {
+ SLIDE_LEFT,
+ SLIDE_RIGHT
msw 2013/01/17 02:28:30 nit: use a comma after trailing enum entries.
dewittj 2013/01/17 21:25:18 Done.
+ };
+
+ class Impl {
msw 2013/01/17 02:28:30 nit: comment.
dewittj 2013/01/17 21:25:18 Gone.
+ public:
+ virtual void TransformView(float scroll_amount) = 0;
+ virtual void RestoreView() = 0;
+ virtual void HideView(SlideDirection direction) = 0;
+ virtual ~Impl() {}
msw 2013/01/17 02:28:30 nit: list the destructor above other functions.
dewittj 2013/01/17 21:25:18 Gone.
+ };
+
SlideOutView();
virtual ~SlideOutView();
@@ -25,12 +38,6 @@ class VIEWS_EXPORT SlideOutView : public views::View,
// Overridden from views::View.
virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
- private:
- enum SlideDirection {
- SLIDE_LEFT,
- SLIDE_RIGHT
- };
-
// Restores the transform and opacity of the view.
void RestoreVisualState();
@@ -40,6 +47,7 @@ class VIEWS_EXPORT SlideOutView : public views::View,
// Overridden from ImplicitAnimationObserver.
virtual void OnImplicitAnimationsCompleted() OVERRIDE;
+ scoped_ptr<Impl> impl_;
float gesture_scroll_amount_;
DISALLOW_COPY_AND_ASSIGN(SlideOutView);

Powered by Google App Engine
This is Rietveld 408576698