Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1183593005: ARM64: remove stack pushes without frame in RegExpExecStub. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: remove stack pushes without frame in RegExpExecStub. RegExpExecStub pushes callee-saved registers without setting up a frame. This confuses the stack iterator. Other architectures do not save these registers. BUG=chromium:487981 LOG=NO TEST=mjsunit/regress/regress-487981 Committed: https://crrev.com/19cdd00d092067edf85e64c6567ec769843a53c2 Cr-Commit-Position: refs/heads/master@{#29120}

Patch Set 1 #

Patch Set 2 : Fix offsets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M src/arm64/code-stubs-arm64.cc View 1 3 chunks +9 lines, -23 lines 0 comments Download
A test/mjsunit/regress/regress-487981.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
PTAL
5 years, 6 months ago (2015-06-18 13:48:03 UTC) #2
jbramley
lgtm
5 years, 6 months ago (2015-06-18 14:19:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183593005/1
5 years, 6 months ago (2015-06-18 14:27:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/6780)
5 years, 6 months ago (2015-06-18 14:49:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183593005/20001
5 years, 6 months ago (2015-06-18 15:20:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-18 15:45:22 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 15:45:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19cdd00d092067edf85e64c6567ec769843a53c2
Cr-Commit-Position: refs/heads/master@{#29120}

Powered by Google App Engine
This is Rietveld 408576698