Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1183563003: Re-land "Modify annotated_run to read factory configs from the slave checkout." (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Re-land "Modify annotated_run to read factory configs from the slave checkout." This patch re-lands r295684 with a fix and testing! Original description: Modify annotated_run to read factory configs from the slave checkout. Currently if you wish to change the recipe a builder uses, or change the other factory properties associated with a builder, you need to restart the master. This change modifies annotated_run.py so that instead of taking the information the master hands us, we ignore it and use the copy of the master config we find in the slave checkout, which should be up-to-date. This should allow us to eliminate a decent number of master restarts. (Though it would still be a good idea to restart the masters periodically so that they don't get too stale). R=phajdan.jr@chormium.org BUG=499071 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295706

Patch Set 1 : original patch #

Patch Set 2 : fix sys.path in dump_master_cfg, improve logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -37 lines) Patch
M scripts/slave/annotated_run.py View 1 4 chunks +94 lines, -28 lines 0 comments Download
M scripts/tools/dump_master_cfg.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/tools/run_recipe.py View 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
Please take a look? The problem with the original patch is that dump_master_cfg.py requires access ...
5 years, 6 months ago (2015-06-16 02:21:49 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 6 months ago (2015-06-16 11:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183563003/20001
5 years, 6 months ago (2015-06-16 19:19:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295706
5 years, 6 months ago (2015-06-16 19:23:29 UTC) #6
dnj
5 years, 6 months ago (2015-06-17 07:58:52 UTC) #7
Message was sent while issue was closed.
On 2015/06/16 19:23:29, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=295706

FYI: This blew up CrOS crbug.com/501190

Fixed now without revert, though!

Powered by Google App Engine
This is Rietveld 408576698