Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1183553002: Adjust VideoCaptureOracle wrt. out of order captures. (Closed)

Created:
5 years, 6 months ago by ericrk
Modified:
5 years, 6 months ago
Reviewers:
miu
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust VideoCaptureOracle wrt. out of order captures. Currently VideoCaptureOracle rejects out-of-order captures. This can cause issues if a capture fast-fails, delivering a failed out of order capture result. This failed result will cause pending successful results to be incorrectly discarded. With browser impl side painting on, this behavior causes a regression in tab capture performance. This change ensures that we only reject out-of-order successful captures (ignoring out-of-order failures). R=miu@chromium.org BUG=498910 Committed: https://crrev.com/36ff3b81b1cf38242e55a684760f9b0e3b4fb2cb Cr-Commit-Position: refs/heads/master@{#334102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M content/browser/media/capture/video_capture_oracle.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle.cc View 3 chunks +12 lines, -7 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle_unittest.cc View 3 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ericrk
5 years, 6 months ago (2015-06-11 20:54:09 UTC) #1
miu
lgtm 100% LGTM. Thanks for finding this and resolving the issue! :)
5 years, 6 months ago (2015-06-12 00:03:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183553002/1
5 years, 6 months ago (2015-06-12 00:05:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 01:24:50 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 01:26:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36ff3b81b1cf38242e55a684760f9b0e3b4fb2cb
Cr-Commit-Position: refs/heads/master@{#334102}

Powered by Google App Engine
This is Rietveld 408576698