Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1183533002: Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 7d53e095d20250ee72a9a0503b4dab94970b4291..e9fd2fc68ca0a5bd7455c67675d9e2bc7e37dce1 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -2521,8 +2521,6 @@ class LibraryErrorsReadyTask extends SourceBasedAnalysisTask {
*/
static Map<String, TaskInput> buildInputs(Source library) {
return <String, TaskInput>{
- 'allLibraryElements':
- IMPORT_EXPORT_SOURCE_CLOSURE.of(library).toListOf(LIBRARY_ELEMENT),
'allErrors': UNITS.of(library).toListOf(DART_ERRORS)
};
}
@@ -3403,7 +3401,11 @@ class VerifyUnitTask extends SourceBasedAnalysisTask {
*/
static Map<String, TaskInput> buildInputs(LibrarySpecificUnit target) {
return <String, TaskInput>{
- 'libraryElement': LIBRARY_ELEMENT.of(target.library),
+ 'resolvedUnits': IMPORT_EXPORT_SOURCE_CLOSURE
+ .of(target.library)
+ .toMapOf(UNITS)
+ .toFlattenList((Source library, Source unit) =>
+ RESOLVED_UNIT.of(new LibrarySpecificUnit(library, unit))),
UNIT_INPUT: RESOLVED_UNIT.of(target),
TYPE_PROVIDER_INPUT: TYPE_PROVIDER.of(AnalysisContextTarget.request)
};
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698