Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: commit_queue.py

Issue 1183513004: Convert dict of builders to list since we do not support properties anymore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit_queue.py
diff --git a/commit_queue.py b/commit_queue.py
index 1b2e444c7e096f67897ebe8aa11b507d4d7a2e7f..b08d4fec7ccff426c3d4dd241ff5ed6273e5b16d 100755
--- a/commit_queue.py
+++ b/commit_queue.py
@@ -113,16 +113,13 @@ def CMDbuilders(parser, args):
The output is a dictionary in the following format:
{
- 'master_name': {
- 'builder_name': {
- 'custom_property': 'value',
- 'testfilter': 'compile'
- },
- 'another_builder': {}
- },
- 'another_master': {
- 'third_builder': {}
- }
+ 'master_name': [
+ 'builder_name',
+ 'another_builder'
+ ],
+ 'another_master': [
+ 'third_builder'
+ ]
}
"""
_, args = parser.parse_args(args)
@@ -138,10 +135,10 @@ def CMDbuilders(parser, args):
masters = {}
if config.HasField('verifiers') and config.verifiers.HasField('try_job'):
for bucket in config.verifiers.try_job.buckets:
- masters.setdefault(bucket.name, {})
+ masters.setdefault(bucket.name, [])
for builder in bucket.builders:
if not builder.HasField('experiment_percentage'):
- masters[bucket.name].setdefault(builder.name, {})
+ masters[bucket.name].append(builder.name)
print json.dumps(masters)
CMDbuilders.func_usage_more = '<path-to-cq-config>'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698