Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1183503003: Add an example of an app that manipulates both a RenderObject tree and has some fn logic in it. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add an example of an app that manipulates both a RenderObject tree and has some fn logic in it. Also: - Make RenderProxyBox non-abstract - Upgrade the old container.dart example - Minor fixes to ui_mode.dart to make this work R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/469cc0df0626ae21f574a3216beb812c1d2f81d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -38 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/examples/widgets/container.dart View 1 chunk +25 lines, -32 lines 0 comments Download
A sky/examples/widgets/spinning_mixed.dart View 1 chunk +91 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/widgets/ui_node.dart View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-11 19:56:06 UTC) #2
Hixie
5 years, 6 months ago (2015-06-11 20:08:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
469cc0df0626ae21f574a3216beb812c1d2f81d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698