[Android log] Fix presubmit check reports in base package

[Android log] Fix presubmit check reports in base package

The presubmit check stop warning about Log calls from classes in the
org.chromium.base package.

Also does some refactoring to simplify logging related checks

BUG=498171
Committed: https://crrev.com/87d9fb6e6ca1f27c7042274c5505de8ded953d80
Cr-Commit-Position: refs/heads/master@{#334135}

[dgn, 2015-06-11 15:33:57]

dgn@chromium.org changed reviewers:
+ jochen@chromium.org

[dgn, 2015-06-11 15:33:58]

Could you PTAL?

https://codereview.chromium.org/1183493002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1183493002/diff/1/PRESUBMIT.py#newcode1341
PRESUBMIT.py:1341: (class_in_base_pattern.search(file_content) and
How can I make it in one check?

I think the closest I got was with something like

class_in_base_without_log_import_pattern = input_api.re.compile(
    r'package org\.chromium\.base;'  # Must be in the base package
     '(?:\n.*)*'                     # There can be some lines of code
     'import(?!.*\.Log;)')           # Eventual imports must not be about Log

But that only works properly with one import statement.

[jochen (gone - plz use gerrit), 2015-06-12 08:46:25]

i think that's good enough as is

lgtm

[dgn, 2015-06-12 09:03:27]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2015-06-12 09:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183493002/1

[commit-bot: I haz the power, 2015-06-12 09:15:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-12 09:16:22]

Patchset 1 (id:??) landed as
https://crrev.com/87d9fb6e6ca1f27c7042274c5505de8ded953d80
Cr-Commit-Position: refs/heads/master@{#334135}