Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: Source/devtools/front_end/ui_lazy/OverviewGrid.js

Issue 1183483011: DevTools: Support popover on timeline overview. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: index-based -> frame-based Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ui/Popover.js ('k') | Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui_lazy/OverviewGrid.js
diff --git a/Source/devtools/front_end/ui_lazy/OverviewGrid.js b/Source/devtools/front_end/ui_lazy/OverviewGrid.js
index 328581392b9d65a0937d06f2355346e04797e8ba..d3a39dad6aa7bbb2e3f0a32eba6b0bf1129e476a 100644
--- a/Source/devtools/front_end/ui_lazy/OverviewGrid.js
+++ b/Source/devtools/front_end/ui_lazy/OverviewGrid.js
@@ -130,7 +130,7 @@ WebInspector.OverviewGrid.prototype = {
*/
setResizeEnabled: function(enabled)
{
- this._window.setEnabled(!!enabled);
+ this._window.setEnabled(enabled);
}
}
@@ -166,11 +166,6 @@ WebInspector.OverviewGrid.Window = function(parentElement, dividersLabelBarEleme
this._overviewWindowBordersElement = parentElement.createChild("div", "overview-grid-window-rulers");
parentElement.createChild("div", "overview-grid-dividers-background");
- this._currentPositionElement = parentElement.createChild("div", "overview-grid-current-position");
- this._currentPositionArea = parentElement.createChild("div", "overview-grid-window-area");
- this._currentPositionArea.addEventListener("mousemove", this._onMouseMove.bind(this), true);
- this._currentPositionArea.addEventListener("mouseout", this._hideCurrentPosition.bind(this), true);
-
this._leftResizeElement = parentElement.createChild("div", "overview-grid-window-resizer");
this._leftResizeElement.style.left = 0;
WebInspector.installDragHandle(this._leftResizeElement, this._resizerElementStartDragging.bind(this), this._leftResizeElementDragging.bind(this), null, "ew-resize");
@@ -206,30 +201,7 @@ WebInspector.OverviewGrid.Window.prototype = {
*/
setEnabled: function(enabled)
{
- enabled = !!enabled;
- if (this._enabled === enabled)
- return;
this._enabled = enabled;
- this._currentPositionArea.style.cursor = enabled ? "text" : "";
- if (!enabled)
- this._hideCurrentPosition();
- },
-
- _hideCurrentPosition: function()
- {
- this._currentPositionElement.style.visibility = "hidden";
- },
-
- /**
- * @param {!Event} event
- */
- _onMouseMove: function(event)
- {
- if (!this._enabled)
- return;
- var x = event.offsetX + event.target.offsetLeft;
- this._currentPositionElement.style.left = x + "px";
- this._currentPositionElement.style.visibility = "visible";
},
/**
« no previous file with comments | « Source/devtools/front_end/ui/Popover.js ('k') | Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698