Issue 1183483006: Serializer: clear string hash for code serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1183483006: Serializer: clear string hash for code serializer. (Closed)

Created:
5 years, 6 months ago by Yang

Modified:
5 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev, Yang

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Serializer: clear string hash for code serializer. R=jochen@chromium.org BUG=v8:4179 LOG=N Committed: https://crrev.com/a0342678e865337215f9195f983c6013b60e7641 Cr-Commit-Position: refs/heads/master@{#29016}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	src/snapshot/serialize.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/snapshot/serialize.cc	View		2 chunks	+22 lines, -14 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183483006/1

5 years, 6 months ago (2015-06-15 08:10:35 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/a0342678e865337215f9195f983c6013b60e7641 Cr-Commit-Position: refs/heads/master@{#29016}

5 years, 6 months ago (2015-06-15 08:41:34 UTC) #6

Yang

5 years, 6 months ago (2015-06-17 06:45:07 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1186173004/ by yangguo@chromium.org.

The reason for reverting is: This led to the roll being stuck:
https://codereview.chromium.org/1189863003/.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages