Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1183453005: fixes #226 super == and fixes #227 escape \r \f (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M lib/src/codegen/js_codegen.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/js/builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M test/codegen/expect/misc.js View 2 chunks +25 lines, -0 lines 0 comments Download
M test/codegen/expect/misc.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M test/codegen/misc.dart View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
a couple of small fixes to get package:test closer to running
5 years, 6 months ago (2015-06-16 23:31:49 UTC) #2
vsm
lgtm
5 years, 6 months ago (2015-06-16 23:51:41 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-16 23:52:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d1d3bfb7c3d59306b8f858119057152d89676ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698