Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1183453004: Track changes to standalone vmservice in mojo and sky embedders. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
Hixie, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Track changes to standalone vmservice in mojo and sky embedders. Standalone changes were in https://codereview.chromium.org/1166433008/ R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6846459d060baec6981c2aaa6327b020f52bc264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/dart/embedder/vmservice/server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/script/dart_service_isolate/server.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rmacnak
5 years, 6 months ago (2015-06-16 23:27:31 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-16 23:40:19 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 6 months ago (2015-06-16 23:51:04 UTC) #7
rmacnak
5 years, 6 months ago (2015-06-16 23:58:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6846459d060baec6981c2aaa6327b020f52bc264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698