Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 1183443002: Reland: Introduce the devices Mojo app (Closed)

Created:
5 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Introduce the devices Mojo app It's a small Mojo app that currently only hosts USB device services. This CL adds the app along with an apptest suite (run manually with mojo_runner mojo:devices_apptests). The app is hooked up to Chrome to run in the browser process, though there are currently no production code paths which cause the app to launch. The original CL (https://codereview.chromium.org/1165223004/) was reverted for breaking Win8 GN builds, because the "midi" component target depends on //device/usb. This is being relanded with no logic changes, just some shuffling of sources into different targets. I've decided to move all the USB mojo service code into devices_app, which allows previous //device/usb dependents to remain unaffected by the introduction of mojo support. Component targets depending on mojo is a bad time for everyone. BUG=498557 TBR=reillyg@chromium.org,sky@chromium.org TBR=eroman@chromium.org - code moving from device/usb to device/devices_app/usb requires net/base in DEPS Committed: https://crrev.com/0fa66a8dc57470d805c22eea20c29dfec2c4d634 Cr-Commit-Position: refs/heads/master@{#333975}

Patch Set 1 #

Patch Set 2 : gn check... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+689 lines, -2516 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_device_client.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M device/BUILD.gn View 2 chunks +5 lines, -4 lines 0 comments Download
M device/core/device_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M device/core/device_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M device/device_tests.gyp View 4 chunks +4 lines, -2 lines 0 comments Download
A device/devices_app/BUILD.gn View 1 1 chunk +73 lines, -0 lines 0 comments Download
A device/devices_app/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + device/devices_app/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A device/devices_app/devices_app.h View 1 chunk +81 lines, -0 lines 0 comments Download
A device/devices_app/devices_app.cc View 1 chunk +175 lines, -0 lines 0 comments Download
A device/devices_app/devices_app.gyp View 1 chunk +61 lines, -0 lines 0 comments Download
A device/devices_app/devices_apptest.cc View 1 chunk +56 lines, -0 lines 0 comments Download
A + device/devices_app/main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A + device/devices_app/usb/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + device/devices_app/usb/device_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + device/devices_app/usb/device_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A + device/devices_app/usb/device_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + device/devices_app/usb/device_manager_impl.h View 3 chunks +20 lines, -12 lines 0 comments Download
A device/devices_app/usb/device_manager_impl.cc View 1 chunk +159 lines, -0 lines 0 comments Download
A + device/devices_app/usb/device_manager_impl_unittest.cc View 5 chunks +16 lines, -39 lines 0 comments Download
A + device/devices_app/usb/public/cpp/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A + device/devices_app/usb/public/cpp/device_manager_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + device/devices_app/usb/public/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/devices_app/usb/public/interfaces/device.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/devices_app/usb/public/interfaces/device_manager.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/devices_app/usb/type_converters.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + device/devices_app/usb/type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
D device/usb/device_impl.h View 1 chunk +0 lines, -140 lines 0 comments Download
D device/usb/device_impl.cc View 1 chunk +0 lines, -347 lines 0 comments Download
D device/usb/device_impl_unittest.cc View 1 chunk +0 lines, -707 lines 0 comments Download
D device/usb/device_manager_impl.h View 1 chunk +0 lines, -66 lines 0 comments Download
D device/usb/device_manager_impl.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D device/usb/device_manager_impl_unittest.cc View 1 chunk +0 lines, -256 lines 0 comments Download
D device/usb/public/cpp/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D device/usb/public/cpp/device_manager_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
D device/usb/public/cpp/device_manager_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D device/usb/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D device/usb/public/interfaces/device.mojom View 1 chunk +0 lines, -263 lines 0 comments Download
D device/usb/public/interfaces/device_manager.mojom View 1 chunk +0 lines, -48 lines 0 comments Download
D device/usb/type_converters.h View 1 chunk +0 lines, -104 lines 0 comments Download
D device/usb/type_converters.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +0 lines, -32 lines 0 comments Download
M device/usb/usb_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183443002/20001
5 years, 6 months ago (2015-06-11 17:18:20 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 17:25:55 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 17:27:37 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0fa66a8dc57470d805c22eea20c29dfec2c4d634
Cr-Commit-Position: refs/heads/master@{#333975}

Powered by Google App Engine
This is Rietveld 408576698