Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 118343004: Reland of http://crrev.com/241548. (Closed)

Created:
7 years ago by robertshield
Modified:
7 years ago
Reviewers:
csharp
CC:
chromium-reviews, grt (UTC plus 2), Sigurður Ásgeirsson, cpu_(ooo_6.6-7.5), rvargas (doing something else)
Visibility:
Public.

Description

Reland of http://crrev.com/241548. It broke on the main waterfall after going through the CQ. Two changes: * No-op the loading test on 64-bit. * Remove the 'IgnoreAllDefaultLibraries' directive. This seems to exclude the CRT on some builders. Original CL description: Chrome browser process DLL blacklist. This patch allows for blocking of module loading in the browser process. It does not actually prevent any modules from loading. Original Review URL: https://codereview.chromium.org/107663008 BUG=329023 TEST=chrome_elf_unittests.exe TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+855 lines, -64 lines) Patch
M chrome/app/chrome_exe_main_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M chrome_elf/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome_elf/blacklist.gypi View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome_elf/blacklist/blacklist.h View 1 chunk +52 lines, -0 lines 0 comments Download
A chrome_elf/blacklist/blacklist.cc View 1 chunk +274 lines, -0 lines 0 comments Download
A chrome_elf/blacklist/blacklist_interceptions.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome_elf/blacklist/blacklist_interceptions.cc View 1 chunk +227 lines, -0 lines 0 comments Download
A chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_dll_1.cc View 1 chunk +3 lines, -7 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_dll_1.def View 1 chunk +1 line, -4 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_dll_2.cc View 1 chunk +7 lines, -8 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_dll_2.def View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_dll_3.cc View 1 chunk +4 lines, -10 lines 0 comments Download
A chrome_elf/blacklist/test/blacklist_test_dll_3.lib View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_main.cc View 1 chunk +7 lines, -9 lines 0 comments Download
A chrome_elf/blacklist/test/blacklist_test_main_dll.h View 1 chunk +10 lines, -0 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_main_dll.cc View 1 chunk +6 lines, -9 lines 0 comments Download
A + chrome_elf/blacklist/test/blacklist_test_main_dll.def View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome_elf/chrome_elf.def View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/chrome_elf.gyp View 5 chunks +19 lines, -2 lines 0 comments Download
M chrome_elf/chrome_elf_main.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/chrome_elf_main.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M chrome_elf/version_assembly_manifest_action.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/118343004/1
7 years ago (2013-12-18 18:25:37 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=237991
7 years ago (2013-12-19 01:24:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/118343004/1
7 years ago (2013-12-19 13:57:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=238382
7 years ago (2013-12-19 15:14:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/118343004/1
7 years ago (2013-12-19 15:20:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=238554
7 years ago (2013-12-19 21:01:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/118343004/1
7 years ago (2013-12-19 21:05:01 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-19 23:16:01 UTC) #8
Message was sent while issue was closed. 
Change committed as 241972

Powered by Google App Engine
This is Rietveld 408576698