Refactor inline_login_ui

chrome/browser/ui/webui/chromeos/login/inline_login_handler_cros_impl.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_INLINE_LOGIN_HANDLER_CROS_IMPL_H_
+#define CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_INLINE_LOGIN_HANDLER_CROS_IMPL_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/ui/webui/signin/inline_login_handler.h"
+
+namespace chromeos {
+
+class OAuth2TokenFetcher;
+
+// Implementation for the inline login WebUI handler on ChromeOS.
+class InlineLoginHandlerCrosImpl : public ::InlineLoginHandler {

[xiyuan, 2013/12/18 21:27:59]

nit: Suggest to call it InlineLoginHandlerChromeOS to be consistent. "Cros" is
not standard and it should be a post-fix rather than in the middle.

[guohui, 2013/12/18 22:39:17]

Done.

+ public:
+  explicit InlineLoginHandlerCrosImpl();
+  virtual ~InlineLoginHandlerCrosImpl();
+
+ private:
+  // InlineLoginHandler overrides:
+  virtual void CompleteLogin(const base::ListValue* args) OVERRIDE;
+
+  class InlineLoginUIOAuth2Delegate;

[xiyuan, 2013/12/18 21:27:59]

nit: move this to immediate after private:

[guohui, 2013/12/18 22:39:17]

Done.

+  scoped_ptr<InlineLoginUIOAuth2Delegate> oauth2_delegate_;
+  scoped_ptr<chromeos::OAuth2TokenFetcher> oauth2_token_fetcher_;
+
+  DISALLOW_COPY_AND_ASSIGN(InlineLoginHandlerCrosImpl);
+};
+
+} // namespace chromeos
+
+#endif  // CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_INLINE_LOGIN_HANDLER_CROS_IMPL_H_