Issue 11834003: Fixed CreatePlatformFile to take in account that |error| can

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11834003: Fixed CreatePlatformFile to take in account that |error| can (Closed)

Created:
7 years, 11 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 11 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fixed CreatePlatformFile to take in account that |error| can be null. This is causing these crashes https://code.google.com/p/chromium/issues/detail?id=169129 BUG=169129, 168890 TEST=crashes be gone Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175980

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	base/platform_file.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

7 years, 11 months ago (2013-01-10 02:57:23 UTC) #3

Lgtm
On Jan 9, 2013 5:07 PM, <cpu@chromium.org> wrote:

> darin verbally lgtm it.
>
>
https://codereview.chromium.**org/11834003/<https://codereview.chromium.org/1...
>

Expand Messages | Collapse Messages