Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 11834002: app_list: Split app_list_controller.* into two smaller parts. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, Aaron Boodman, ben+watch_chromium.org, sadrul, tfarina, chromium-apps-reviews_chromium.org, benwells, tapted
Visibility:
Public.

Description

app_list: Split app_list_controller.* into two smaller parts. - One for AppListControllerDelegate class. - Other for the AppList - Init/Show functions. R=xiyuan@chromium.org TBR=sky@chromium.org # for trivial include updates Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175961

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -150 lines) Patch
M chrome/browser/extensions/extension_install_ui_default.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_controller.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_controller.cc View 1 chunk +0 lines, -39 lines 0 comments Download
A + chrome/browser/ui/app_list/app_list_controller_delegate.h View 2 chunks +4 lines, -14 lines 0 comments Download
A + chrome/browser/ui/app_list/app_list_controller_delegate.cc View 2 chunks +1 line, -11 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_util.h View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_util.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Hi Xiyuan, please take a look. Thanks,
7 years, 11 months ago (2013-01-09 18:51:03 UTC) #1
xiyuan
+benwells, tapted fyi LGTM
7 years, 11 months ago (2013-01-09 19:07:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11834002/2001
7 years, 11 months ago (2013-01-09 22:38:01 UTC) #3
commit-bot: I haz the power
Presubmit check for 11834002-2001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-09 22:38:15 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 22:42:24 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698