Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1183393003: Empty LayoutObject::pushMappingToContainer(). Assert that not reached. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index e96113c8527123bac9e23bd9410e148474f9f1a9..7b40d150debe9d6c1bb917b541c40f6b782c668f 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -2062,20 +2062,8 @@ void LayoutObject::mapLocalToContainer(const LayoutBoxModelObject* paintInvalida
const LayoutObject* LayoutObject::pushMappingToContainer(const LayoutBoxModelObject* ancestorToStopAt, LayoutGeometryMap& geometryMap) const
{
- ASSERT_UNUSED(ancestorToStopAt, ancestorToStopAt != this);
-
- LayoutObject* container = parent();
- if (!container)
- return nullptr;
-
- // FIXME: this should call offsetFromContainer to share code, but I'm not sure it's ever called.
- LayoutSize offset;
- if (container->hasOverflowClip())
- offset = -LayoutSize(toLayoutBox(container)->scrolledContentOffset());
-
- geometryMap.push(this, offset);
-
- return container;
+ ASSERT_NOT_REACHED();
+ return nullptr;
}
void LayoutObject::mapAbsoluteToLocalPoint(MapCoordinatesFlags mode, TransformState& transformState) const
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698