Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1183383002: Fix Clang compile error. (Closed)

Created:
5 years, 6 months ago by chinyue
Modified:
5 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Clang compile error. cras_client_get_first_dev_type_idx returns a value less than zero on error. pin_device_ should be an int to handle this. BUG=468639 TEST=Build Chrome with Clang. Committed: https://crrev.com/a2771c3a51b23179100db4084c80d7e8e54a9fe1 Cr-Commit-Position: refs/heads/master@{#336061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/audio/cras/cras_input.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
mark a. foltz
lgtm
5 years, 6 months ago (2015-06-17 23:13:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183383002/1
5 years, 6 months ago (2015-06-18 00:35:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/71834)
5 years, 6 months ago (2015-06-18 00:47:19 UTC) #7
chinyue
On 2015/06/18 00:47:19, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-18 01:57:30 UTC) #9
chinyue
Hi miu, tommi, Could you please take a look, thanks!
5 years, 6 months ago (2015-06-24 07:32:53 UTC) #11
miu
lgtm, but it's really odd that cras_client_get_first_dev_type_idx() returns an int, while cras_client_add_pinned_stream() takes a uint32 ...
5 years, 6 months ago (2015-06-24 19:34:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183383002/1
5 years, 6 months ago (2015-06-25 01:08:54 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 01:18:11 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 01:19:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2771c3a51b23179100db4084c80d7e8e54a9fe1
Cr-Commit-Position: refs/heads/master@{#336061}

Powered by Google App Engine
This is Rietveld 408576698