Promptly finalize CacheStorage's embedder object.

Promptly finalize CacheStorage's embedder object.

The lifetime of the global object's CacheStorage is that of the global
object, so when it is destructed/finalized, the CacheStorage must
release its embedder object at the same. This so as to prevent the
embedder calling into Blink after it has shut down or when it is in
the process of finalizing and lazily sweeping out its Oilpan heap.

R=haraken,jsbell@chromium.org
BUG=500355
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197236

[sof, 2015-06-16 19:20:41]

sigbjornf@opera.com changed reviewers:
+ gavinp@chromium.org, haraken@chromium.org, jsbell@chromium.org

[sof, 2015-06-16 19:20:41]

please take a look.

[haraken, 2015-06-16 20:09:52]

LGTM

Just to confirm: It is not enough to make CacheStorage eagerly-finalized, right?

[sof, 2015-06-16 20:23:14]

On 2015/06/16 20:09:52, haraken wrote:
> LGTM
> 
> Just to confirm: It is not enough to make CacheStorage eagerly-finalized,
right?

Yes, that is my assumption -- the Persistent<>ly held CacheStorage isn't GCed,
so that object isn't swept out & finalized. Eagerly or not, depending on whether
LAZY_SWEEPING is enabled.

Once the Persistent<> reference on GlobalCacheStorageImpl is no longer needed,
we can move the eager finalization over to CacheStorage, if that's preferable.

[jsbell, 2015-06-16 20:23:55]

lgtm

[sof, 2015-06-16 21:16:57]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-06-16 21:18:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183373006/1

[commit-bot: I haz the power, 2015-06-17 00:49:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 00:49:39]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66894)

[sof, 2015-06-17 05:35:09]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-06-17 05:35:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183373006/1

[commit-bot: I haz the power, 2015-06-17 06:29:47]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197236