4 years, 10 months ago
(2015-06-16 12:13:13 UTC)
#2
yhirano
On 2015/06/16 12:13:13, hiroshige wrote: We cannot use std::string in blink, can we?
4 years, 10 months ago
(2015-06-16 12:53:35 UTC)
#3
On 2015/06/16 12:13:13, hiroshige wrote:
We cannot use std::string in blink, can we?
hiroshige
I thought there are uses of std::string, but they are mostly unit tests... Then shall ...
4 years, 10 months ago
(2015-06-16 14:16:15 UTC)
#4
I thought there are uses of std::string, but they are mostly unit tests...
Then shall we use |const char*| literals?
(I wanted to use std::string to return names such as "WrapperHandle of
WrappedHandle";
|const char*| only returns "WrapperHandle" or "WrappedHandle", but might be
acceptable)
Another candidate might be WebString but I want to avoid it (to avoid
thread-safety issues and complexity of the code).
yhirano
|const char*| literals look fine.
4 years, 10 months ago
(2015-06-17 01:23:57 UTC)
#5
|const char*| literals look fine.
hiroshige
Changed string to const char* in Patch Set 2.
4 years, 10 months ago
(2015-06-17 07:24:18 UTC)
#6
Changed string to const char* in Patch Set 2.
yhirano
lgtm
4 years, 10 months ago
(2015-06-17 07:27:16 UTC)
#7
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59374)
4 years, 10 months ago
(2015-06-18 02:20:52 UTC)
#14
Issue 1183373003: Add WebDataConsumerHandle::debugName()
(Closed)
Created 4 years, 10 months ago by hiroshige
Modified 4 years, 10 months ago
Reviewers: yhirano, tkent
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 0