Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(40)

Issue 1183373003: Add WebDataConsumerHandle::debugName() (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
Reviewers:
tkent, yhirano
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebDataConsumerHandle::debugName() BUG=480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197324

Patch Set 1 #

Patch Set 2 : Use const char* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M public/platform/WebDataConsumerHandle.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
hiroshige
4 years, 10 months ago (2015-06-16 12:13:13 UTC) #2
yhirano
On 2015/06/16 12:13:13, hiroshige wrote: We cannot use std::string in blink, can we?
4 years, 10 months ago (2015-06-16 12:53:35 UTC) #3
hiroshige
I thought there are uses of std::string, but they are mostly unit tests... Then shall ...
4 years, 10 months ago (2015-06-16 14:16:15 UTC) #4
yhirano
|const char*| literals look fine.
4 years, 10 months ago (2015-06-17 01:23:57 UTC) #5
hiroshige
Changed string to const char* in Patch Set 2.
4 years, 10 months ago (2015-06-17 07:24:18 UTC) #6
yhirano
lgtm
4 years, 10 months ago (2015-06-17 07:27:16 UTC) #7
hiroshige
+tkent@ Could you take a look as public/ OWNER?
4 years, 10 months ago (2015-06-17 08:50:55 UTC) #9
tkent
lgtm
4 years, 10 months ago (2015-06-17 23:38:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183373003/20001
4 years, 10 months ago (2015-06-17 23:39:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59374)
4 years, 10 months ago (2015-06-18 02:20:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183373003/20001
4 years, 10 months ago (2015-06-18 05:13:57 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 06:37:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197324

Powered by Google App Engine
This is Rietveld 408576698