Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: Source/core/dom/NodeRenderingTraversal.cpp

Issue 118333005: Refactor RenderTreeBuilder and expose special <dialog> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/NodeRenderingTraversal.h ('k') | Source/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/NodeRenderingTraversal.cpp
diff --git a/Source/core/dom/NodeRenderingTraversal.cpp b/Source/core/dom/NodeRenderingTraversal.cpp
index 97c073e5d2f4ae70711fdd3289a4205677b9a1bd..a40e276470dce78e5778548e9eba5caae0ca8df9 100644
--- a/Source/core/dom/NodeRenderingTraversal.cpp
+++ b/Source/core/dom/NodeRenderingTraversal.cpp
@@ -27,6 +27,7 @@
#include "config.h"
#include "core/dom/NodeRenderingTraversal.h"
+#include "HTMLNames.h"
#include "core/dom/PseudoElement.h"
#include "core/dom/shadow/ComposedTreeWalker.h"
#include "core/rendering/RenderObject.h"
@@ -41,7 +42,11 @@ static bool isRendererReparented(const RenderObject* renderer)
return false;
if (renderer->style() && !renderer->style()->flowThread().isEmpty())
return true;
- if (toElement(renderer->node())->shouldBeReparentedUnderRenderView(renderer->style()))
+ Element& element = toElement(*renderer->node());
+ if (element.isInTopLayer())
+ return true;
+ // FIXME: The spec should not require magical behavior for <dialog>.
+ if (element.hasTagName(HTMLNames::dialogTag) && renderer->style()->position() == AbsolutePosition)
return true;
return false;
}
@@ -129,6 +134,20 @@ RenderObject* previousSiblingRenderer(const Node* node)
return 0;
}
+RenderObject* nextInTopLayer(const Element* element)
+{
+ if (!element->isInTopLayer())
+ return 0;
+ const Vector<RefPtr<Element> >& topLayerElements = element->document().topLayerElements();
+ size_t position = topLayerElements.find(element);
+ ASSERT(position != kNotFound);
+ for (size_t i = position + 1; i < topLayerElements.size(); ++i) {
+ if (RenderObject* renderer = topLayerElements[i]->renderer())
+ return renderer;
+ }
+ return 0;
+}
+
}
} // namespace
« no previous file with comments | « Source/core/dom/NodeRenderingTraversal.h ('k') | Source/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698