Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java

Issue 118333004: Enable ClickListenerTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/data/android/device_files/content_detection/click_listeners.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java
index 2f8f9c02591c545bcae83f9363436dd93c107402..3ea92755834bb6fff23cbd782aff74015de6002e 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java
@@ -4,35 +4,31 @@
package org.chromium.content.browser;
-import org.chromium.base.test.util.DisabledTest;
+import android.test.suitebuilder.annotation.MediumTest;
+
+import org.chromium.base.test.util.Feature;
/**
* Test suite for click listener validation in content detection.
*/
public class ClickListenerTest extends ContentDetectionTestBase {
- /*
@MediumTest
@Feature({"ContentDetection", "TabContents"})
- http://crbug.com/172786
- */
- @DisabledTest
public void testClickContentOnLink() throws Throwable {
startActivityWithTestUrl("content/content_detection/click_listeners.html");
+ assertWaitForPageScaleFactorMatch(1.0f);
// Clicks on addresses in links should change the url.
scrollAndTapNavigatingOut("linktest");
assertTrue(isCurrentTestUrl("content/content_detection/empty.html"));
}
- /*
@MediumTest
@Feature({"ContentDetection", "TabContents"})
- http://crbug.com/172786
- */
- @DisabledTest
public void testClickContentOnJSListener1() throws Throwable {
startActivityWithTestUrl("content/content_detection/click_listeners.html");
+ assertWaitForPageScaleFactorMatch(1.0f);
// Clicks on addresses in elements listening to click events should be
// processed normally without address detection.
@@ -40,14 +36,11 @@ public class ClickListenerTest extends ContentDetectionTestBase {
assertTrue(isCurrentTestUrl("content/content_detection/empty.html"));
}
- /*
@MediumTest
@Feature({"ContentDetection", "TabContents"})
- http://crbug.com/172786
- */
- @DisabledTest
public void testClickContentOnJSListener2() throws Throwable {
startActivityWithTestUrl("content/content_detection/click_listeners.html");
+ assertWaitForPageScaleFactorMatch(1.0f);
// Same as previous test, but using addEventListener instead of onclick.
scrollAndTapNavigatingOut("clicktest2");
« no previous file with comments | « no previous file | content/test/data/android/device_files/content_detection/click_listeners.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698