Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/browser/instant/instant_controller.h

Issue 11833043: Instant Extended: Fallback to local preview if the remote instant page is not ready on user input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor
Patch Set: Addressing sreeram's comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_client.cc ('k') | chrome/browser/instant/instant_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_controller.h
diff --git a/chrome/browser/instant/instant_controller.h b/chrome/browser/instant/instant_controller.h
index 19acbb425454e2a4916421124e47690d34299257..01b2623e2adcf4cd2c1c2f548964c795a8be05d9 100644
--- a/chrome/browser/instant/instant_controller.h
+++ b/chrome/browser/instant/instant_controller.h
@@ -176,6 +176,11 @@ class InstantController {
// Invoked by InstantLoader when the instant page is about to navigate.
void InstantLoaderAboutToNavigateMainFrame(const GURL& url);
+ // Invoked by InstantLoader when it's underlying RenderView is created.
+ // TODO(shishir): We assume that the WebContent's current RenderViewHost is
+ // the RenderViewHost being created which is not always true. Fix this.
+ void InstantLoaderRenderViewCreated();
+
// Invoked by the InstantLoader when the instant page wants to navigate to
// the speicfied URL.
void NavigateToURL(const GURL& url, content::PageTransition transition);
@@ -217,6 +222,11 @@ class InstantController {
// deleted and recreated. Else the refresh is skipped.
void OnStaleLoader();
+ // If the |loader_| being used is in fallback mode, it will be switched back
+ // to the remote loader if the loader is not showing and the omnibox does not
+ // have focus.
+ void MaybeSwitchToRemoteLoader();
+
// If the active tab is an Instant search results page, sets |instant_tab_| to
// point to it. Else, deletes any existing |instant_tab_|.
void ResetInstantTab();
« no previous file with comments | « chrome/browser/instant/instant_client.cc ('k') | chrome/browser/instant/instant_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698