Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: pkg/unittest/lib/src/config.dart

Issue 11833038: Revert changes to _postMessage in r16899 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/src/config.dart
diff --git a/pkg/unittest/lib/src/config.dart b/pkg/unittest/lib/src/config.dart
index 9d482aedb7b3f7f3a5fec317b04fe9e20028fb93..b26bdce22a8634aa170fcdeae3d3eb89676e8a28 100644
--- a/pkg/unittest/lib/src/config.dart
+++ b/pkg/unittest/lib/src/config.dart
@@ -38,7 +38,7 @@ class Configuration {
*/
void onInit() {
_receivePort = new ReceivePort();
- notifyController('unittest-suite-wait-for-done');
+ _postMessage('unittest-suite-wait-for-done');
}
/** Called as soon as the unittest framework starts running. */
@@ -134,7 +134,7 @@ class Configuration {
*/
void onDone(bool success) {
if (success) {
- notifyController('unittest-suite-success');
+ _postMessage('unittest-suite-success');
_receivePort.close();
} else {
_receivePort.close();
@@ -166,7 +166,11 @@ class Configuration {
* compact_vm_config), can safely override this method to avoid printing extra
* mesages in the console.
*/
+ // TODO(sigmund): find a way to unify notifyController and _postMessage
void notifyController(String message) {
+ }
+
+ _postMessage(String message) {
// In dart2js browser tests, the JavaScript-based test controller
// intercepts calls to print and listens for "secret" messages.
print(message);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698