Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 11833027: Add 'FLAG num' in tr.aff to fix a crash in heapcheck test (Closed)

Created:
6 years, 5 months ago by please use gerrit instead
Modified:
6 years, 5 months ago
CC:
chromium-reviews, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git@master
Visibility:
Public.

Description

Add 'FLAG num' in tr.aff to fix a crash in heapcheck test The heapcheck test crashes in SpellCheckTest.SpellCheckText when attempting to load tr-TR-3-0.bdic file, because tr.aff is missing a 'FLAG num' directive. Other tests do not crash. This change is to download the pull the dictionary from a Google code website instead of a Firefox website. The new download location includes the 'FLAG num' directive, which fixes the crash. BUG=168825 Committed: 175986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M README.chromium View 2 chunks +7 lines, -1 line 0 comments Download
M README_tr.txt View 1 chunk +1 line, -2 lines 0 comments Download
M tr.aff View 1 chunk +2 lines, -1 line 0 comments Download
A + tr-TR-4-0.bdic View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
please use gerrit instead
Rlp: PTAL.
6 years, 5 months ago (2013-01-10 01:47:44 UTC) #1
rpetterson
On 2013/01/10 01:47:44, Rouslan Solomakhin wrote: > Rlp: PTAL. Good find. LGTM. One nit. Do ...
6 years, 5 months ago (2013-01-10 01:53:52 UTC) #2
please use gerrit instead
On 2013/01/10 01:53:52, rpetterson wrote: > On 2013/01/10 01:47:44, Rouslan Solomakhin wrote: > > Rlp: ...
6 years, 5 months ago (2013-01-10 01:59:15 UTC) #3
rpetterson
On 2013/01/10 01:59:15, Rouslan Solomakhin wrote: > On 2013/01/10 01:53:52, rpetterson wrote: > > On ...
6 years, 5 months ago (2013-01-10 02:00:03 UTC) #4
groby-ooo-7-16
Drive-by nit: Can we error-check in the bdic tool that there is a FLAG directive?
6 years, 5 months ago (2013-01-10 02:05:21 UTC) #5
rpetterson
On 2013/01/10 02:05:21, groby wrote: > Drive-by nit: Can we error-check in the bdic tool ...
6 years, 5 months ago (2013-01-10 02:14:27 UTC) #6
please use gerrit instead
6 years, 5 months ago (2013-01-10 02:15:10 UTC) #7
Message was sent while issue was closed.
On 2013/01/10 02:05:21, groby wrote:
> Drive-by nit: Can we error-check in the bdic tool that there is a FLAG
> directive?

Great idea! I filed http://crbug.com/169166 for myself to track it.

Powered by Google App Engine
This is Rietveld 408576698