Add 'FLAG num' in tr.aff to fix a crash in heapcheck test

Add 'FLAG num' in tr.aff to fix a crash in heapcheck test

The heapcheck test crashes in SpellCheckTest.SpellCheckText when attempting to
load tr-TR-3-0.bdic file, because tr.aff is missing a 'FLAG num' directive.
Other tests do not crash. This change is to download the pull the dictionary
from a Google code website instead of a Firefox website. The new download
location includes the 'FLAG num' directive, which fixes the crash.

BUG=168825
Committed: 175986

[please use gerrit instead, 2013-01-10 01:47:44]

Rlp: PTAL.

[rpetterson, 2013-01-10 01:53:52]

On 2013/01/10 01:47:44, Rouslan Solomakhin wrote:
> Rlp: PTAL.

Good find. LGTM.

One nit. Do you think this warrants 4-0 though? I would argue that it's still
3-0 because the previous 3-0 was incorrectly formatted. Or perhaps 3-1.

[please use gerrit instead, 2013-01-10 01:59:15]

On 2013/01/10 01:53:52, rpetterson wrote:
> On 2013/01/10 01:47:44, Rouslan Solomakhin wrote:
> > Rlp: PTAL.
> 
> Good find. LGTM.
> 
> One nit. Do you think this warrants 4-0 though? I would argue that it's still
> 3-0 because the previous 3-0 was incorrectly formatted. Or perhaps 3-1.

I've had an internal battle with this as well. From 3-0 to 4-0 seems to be a
large change for a one-line change in tr.aff. I decided to bump the major
version in the end because the directions state: "Increment the major version
number if you're updating either dic or aff files. Increment the minor version
number if you're updating only dic_delta files."

[rpetterson, 2013-01-10 02:00:03]

On 2013/01/10 01:59:15, Rouslan Solomakhin wrote:
> On 2013/01/10 01:53:52, rpetterson wrote:
> > On 2013/01/10 01:47:44, Rouslan Solomakhin wrote:
> > > Rlp: PTAL.
> > 
> > Good find. LGTM.
> > 
> > One nit. Do you think this warrants 4-0 though? I would argue that it's
still
> > 3-0 because the previous 3-0 was incorrectly formatted. Or perhaps 3-1.
> 
> I've had an internal battle with this as well. From 3-0 to 4-0 seems to be a
> large change for a one-line change in tr.aff. I decided to bump the major
> version in the end because the directions state: "Increment the major version
> number if you're updating either dic or aff files. Increment the minor version
> number if you're updating only dic_delta files."

Got it. Well, +1 for consistency. :)

[groby-ooo-7-16, 2013-01-10 02:05:21]

Drive-by nit: Can we error-check in the bdic tool that there is a FLAG
directive?

[rpetterson, 2013-01-10 02:14:27]

On 2013/01/10 02:05:21, groby wrote:
> Drive-by nit: Can we error-check in the bdic tool that there is a FLAG
> directive?

+1

[please use gerrit instead, 2013-01-10 02:15:10]

On 2013/01/10 02:05:21, groby wrote:
> Drive-by nit: Can we error-check in the bdic tool that there is a FLAG
> directive?

Great idea! I filed http://crbug.com/169166 for myself to track it.