Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 11833021: Rename Native messaging hosts directory to native_hosts. (Closed)

Created:
7 years, 11 months ago by Sergey Ulanov
Modified:
7 years, 11 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Rename Native messaging hosts directory to native_hosts. Previously the directory name contained spaces which is problematic when applying patches on trybots. In the future this directory will go away with the new native host installation mechanism, so the name doesn't really matter. BUG=142915 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175958

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -76 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/native_messaging/Native Hosts/echo.py View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/test/data/native_messaging/Native Hosts/empty_app.py View 1 chunk +0 lines, -23 lines 0 comments Download
A + chrome/test/data/native_messaging/native_hosts/echo.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/native_messaging/native_hosts/empty_app.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
7 years, 11 months ago (2013-01-09 23:32:33 UTC) #1
Matt Perry
LGTM as long as this is temporary. (Chrome's convention is to use Folder Name as ...
7 years, 11 months ago (2013-01-10 00:09:44 UTC) #2
Sergey Ulanov
On 2013/01/10 00:09:44, Matt Perry wrote: > LGTM as long as this is temporary. (Chrome's ...
7 years, 11 months ago (2013-01-10 00:30:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11833021/2001
7 years, 11 months ago (2013-01-10 00:36:36 UTC) #4
commit-bot: I haz the power
Can't process patch for file chrome/test/data/native_messaging/native_hosts/empty_app.py. Unexpected git diff output name Hosts/empty_app.py b/chrome/test/data/native_messaging/native_hosts/empty_app.py.
7 years, 11 months ago (2013-01-10 00:36:41 UTC) #5
Sergey Ulanov
7 years, 11 months ago (2013-01-10 00:47:26 UTC) #6
On 2013/01/10 00:36:41, I haz the power (commit-bot) wrote:
> Can't process patch for file
> chrome/test/data/native_messaging/native_hosts/empty_app.py.
> Unexpected git diff output name Hosts/empty_app.py
> b/chrome/test/data/native_messaging/native_hosts/empty_app.py.

That's exactly why I need this change.

Powered by Google App Engine
This is Rietveld 408576698