Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java

Issue 11833019: Fix NPE part 2 (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
diff --git a/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java b/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
index c9cc0f4d9d50e4d8dca761734a4dc8587d47916c..5d4cc01069d345e9a772e508f00e1ee7d616027b 100644
--- a/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
+++ b/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
@@ -125,7 +125,12 @@ public class WipBackendImpl extends WipBackendBase {
private String readHttpResponseContent(InetSocketAddress socketAddress, String resource,
LoggerFactory loggerFactory) throws IOException {
- ConnectionLogger browserConnectionLogger = loggerFactory.newBrowserConnectionLogger();
+ ConnectionLogger browserConnectionLogger;
+ if (loggerFactory == null) {
+ browserConnectionLogger = null;
+ } else {
+ browserConnectionLogger = loggerFactory.newBrowserConnectionLogger();
+ }
final SocketWrapper socketWrapper = new SocketWrapper(
socketAddress, DEFAULT_CONNECTION_TIMEOUT_MS, browserConnectionLogger,
HandshakeUtil.ASCII_CHARSET);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698