plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java - Issue 11833010: Expose liveedit compile error data in SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java

Issue 11833010: Expose liveedit compile error data in SDK (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: fcr Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java ('k') | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PushChangesWizard.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java

diff --git a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java

index 3d77bf390b734963044fcf2e7b3f98e055281fd5..6775a11ce94a7e2e4dcb951597356f28e8aa7e03 100644

--- a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java

+++ b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java

@@ -64,7 +64,7 @@ class PreviewLoader implements ValueSource<Optional<PreviewLoader.Data>> {

updater.reportChanged(this);

UpdatableScript.UpdateCallback callback = new UpdatableScript.UpdateCallback() {

- public void failure(String message) {

+ public void failure(String message, UpdatableScript.Failure failure) {

Optional<Data> error = createErrorOptional(

new Message(NLS.bind(Messages.PreviewLoader_FAILED_TO_GET, message),

MessagePriority.WARNING));