Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 11833002: Cleanup: Add fileapi::GetIsolatedFileSystemRootURIString (Closed)

Created:
7 years, 11 months ago by kinuko
Modified:
7 years, 11 months ago
Reviewers:
Lei Zhang, benwells, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Add fileapi::GetIsolatedFileSystemRootURIString to hide the details how we create a root URI string for IsolatedFileSystems from each extension code. BUG=none TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176036

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M chrome/renderer/extensions/file_system_natives.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M webkit/fileapi/file_system_util.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_util.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Can you take a look? Should be an innocent cleanup. benwells@: chrome/renderer/extensions/file_system_natives.cc thestig@: chrome/renderer/extensions/media_galleries_custom_bindings.cc Thx,
7 years, 11 months ago (2013-01-09 17:02:06 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/11833002/diff/1/webkit/fileapi/file_system_util.h File webkit/fileapi/file_system_util.h (right): https://codereview.chromium.org/11833002/diff/1/webkit/fileapi/file_system_util.h#newcode127 webkit/fileapi/file_system_util.h:127: // for |filesystem_id|. If the |optional_root_name| is given ...
7 years, 11 months ago (2013-01-09 21:29:03 UTC) #2
benwells
lgtm
7 years, 11 months ago (2013-01-10 03:26:54 UTC) #3
kinuko
tzik: can you give a quick look at the fileapi changes? Thx, https://codereview.chromium.org/11833002/diff/1/webkit/fileapi/file_system_util.h File webkit/fileapi/file_system_util.h ...
7 years, 11 months ago (2013-01-10 04:03:14 UTC) #4
tzik
lgtm
7 years, 11 months ago (2013-01-10 05:24:19 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 05:26:07 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698