Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 118328: chrome.exe --package-extension (Closed)

Created:
11 years, 6 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

chrome.exe --package-extension generates .crx from extension directory R=aa BUG=12114 Committed: http://src.chromium.org/viewvc/17927

Patch Set 1 #

Patch Set 2 : pre CR #

Patch Set 3 : moved pem methods to extension_creator #

Total comments: 24

Patch Set 4 : pre CR #

Patch Set 5 : more #

Patch Set 6 : CR changes #

Patch Set 7 : moved pem functions. #

Total comments: 24

Patch Set 8 : added openssl test #

Patch Set 9 : cr changes #

Total comments: 4

Patch Set 10 : last changes #

Patch Set 11 : added openssl key, linux/mac compile fixes #

Patch Set 12 : more linux/mac compile fixes #

Patch Set 13 : please compile! #

Patch Set 14 : blargh! #

Patch Set 15 : final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3420 lines, -2879 lines) Patch
M chrome/browser/browser.vcproj View 10 11 1 chunk +2826 lines, -2818 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +44 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_creator.h View 1 2 3 5 6 7 8 1 chunk +69 lines, -0 lines 0 comments Download
chrome/browser/extensions/extension_creator.cc View 1 2 3 5 6 7 8 9 10 11 1 chunk +275 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 6 7 8 9 10 11 1 chunk +2 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 6 7 8 9 10 11 12 2 chunks +65 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 2 3 4 5 6 4 chunks +17 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 5 6 6 chunks +90 lines, -14 lines 0 comments Download
M chrome/common/extensions/extension_unpacker.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/test/data/extensions/good.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/good2.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/extensions/openssl_privkey_asn1.pem View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/page_action.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/theme.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/theme2.crx View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rafaelw
please review pending unittests
11 years, 6 months ago (2009-06-07 02:18:37 UTC) #1
Aaron Boodman
Logic seems good. Just factoring/style nits. http://codereview.chromium.org/118328/diff/36/38 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/118328/diff/36/38#newcode687 Line 687: // TODO(aa): ...
11 years, 6 months ago (2009-06-07 02:38:28 UTC) #2
rafaelw
check it http://codereview.chromium.org/118328/diff/36/38 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/118328/diff/36/38#newcode687 Line 687: // TODO(aa): Is it OK to ...
11 years, 6 months ago (2009-06-08 00:44:03 UTC) #3
rafaelw
Had to move PEM functions to extension.cc/h because in the signature that's coming next, extension ...
11 years, 6 months ago (2009-06-08 15:28:58 UTC) #4
Aaron Boodman
http://codereview.chromium.org/118328/diff/1041/67 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/118328/diff/1041/67#newcode687 Line 687: ExtensionErrorReporter *error_reporter = I'd rather not use ExtensionErrorReporter ...
11 years, 6 months ago (2009-06-08 18:31:36 UTC) #5
rafaelw
http://codereview.chromium.org/118328/diff/1041/67 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/118328/diff/1041/67#newcode687 Line 687: ExtensionErrorReporter *error_reporter = On 2009/06/08 18:31:36, Aaron Boodman ...
11 years, 6 months ago (2009-06-08 19:28:06 UTC) #6
Aaron Boodman
lgtm! http://codereview.chromium.org/118328/diff/86/1046 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/118328/diff/86/1046#newcode47 Line 47: #include "chrome/common/extensions/extension_error_reporter.h" This can be removed now. ...
11 years, 6 months ago (2009-06-08 19:33:01 UTC) #7
rafaelw
11 years, 6 months ago (2009-06-08 19:44:18 UTC) #8
http://codereview.chromium.org/118328/diff/86/1046
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/118328/diff/86/1046#newcode47
Line 47: #include "chrome/common/extensions/extension_error_reporter.h"
On 2009/06/08 19:33:01, Aaron Boodman wrote:
> This can be removed now.

Done.

http://codereview.chromium.org/118328/diff/86/1046#newcode700
Line 700: std::wstring parent_dir = src_dir.value();
On 2009/06/08 19:33:01, Aaron Boodman wrote:
> This won't work on mac/linux (value() is not a wstring there).
> 
> You can use src_dir.DirName() to get the parent instead in a cross-platform
way.

Done.

Powered by Google App Engine
This is Rietveld 408576698