Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: sky/engine/core/script/dart_controller.cc

Issue 1183253002: Update Dart dependency and patch dart_controller to account for (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/script/dart_controller.cc
diff --git a/sky/engine/core/script/dart_controller.cc b/sky/engine/core/script/dart_controller.cc
index 04b03c117f329dbea5da92a91cdc32868e24a421..18e5532ba064734c73f83ebc05c4f58a3a4f5d78 100644
--- a/sky/engine/core/script/dart_controller.cc
+++ b/sky/engine/core/script/dart_controller.cc
@@ -238,6 +238,7 @@ static void EnsureHandleWatcherStarted() {
static Dart_Isolate IsolateCreateCallback(const char* script_uri,
const char* main,
const char* package_root,
+ Dart_IsolateFlags* flags,
void* callback_data,
char** error) {
@@ -248,6 +249,7 @@ static Dart_Isolate IsolateCreateCallback(const char* script_uri,
"main",
kDartIsolateSnapshotBuffer,
nullptr,
+ nullptr,
error);
CHECK(isolate) << error;
dart_state->SetIsolate(isolate);
@@ -278,7 +280,7 @@ static Dart_Isolate IsolateCreateCallback(const char* script_uri,
CHECK(kDartIsolateSnapshotBuffer);
DartState* dart_state = new DartState();
Dart_Isolate isolate = Dart_CreateIsolate("sky:handle_watcher", "",
- kDartIsolateSnapshotBuffer, dart_state, error);
+ kDartIsolateSnapshotBuffer, nullptr, dart_state, error);
CHECK(isolate) << error;
dart_state->SetIsolate(isolate);
@@ -324,7 +326,7 @@ void DartController::CreateIsolateFor(PassOwnPtr<DOMDartState> state) {
dom_dart_state_ = state;
Dart_Isolate isolate = Dart_CreateIsolate(
dom_dart_state_->url().string().utf8().data(), "main",
- kDartIsolateSnapshotBuffer,
+ kDartIsolateSnapshotBuffer, nullptr,
static_cast<DartState*>(dom_dart_state_.get()), &error);
Dart_SetMessageNotifyCallback(MessageNotifyCallback);
CHECK(isolate) << error;
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698