LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html - Issue 1183233002: Split RW hint into Width and Viewport-Width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html

Issue 1183233002: Split RW hint into Width and Viewport-Width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed and added layout tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html

diff --git a/LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html b/LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html

index fdd70821515f37678548bb3f1cde8dfaa0b3b1b7..f80baa6d4072390f64f95de77cd0e33c6f3edb92 100644

--- a/LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html

+++ b/LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html

@@ -1,17 +1,19 @@

<!DOCTYPE html>

-<meta http-equiv="Accept-CH" content="DPR, RW">

+<meta http-equiv="Accept-CH" content="DPR, Width, Viewport-Width">

-<img id="testimg1" src="resources/image-checks-for-rw.php?rw=480" sizes="60vw">

-<img id="testimg2" sizes="40vw" src="resources/image-checks-for-rw.php?rw=320" sizes="60vw">

-<img id="testimg3" sizes="50vw" src="resources/image-checks-for-rw.php?rw=400">

+<img id="testimg1" src="resources/image-checks-for-width.php?rw=480" sizes="60vw">

+<img id="testimg2" sizes="40vw" src="resources/image-checks-for-width.php?rw=320" sizes="60vw">

+<img id="testimg3" sizes="50vw" src="resources/image-checks-for-width.php?rw=400">

+<img id="testimg4" sizes="50vw" src="resources/image-checks-for-viewport-width.php?viewport=800">

- var t = async_test('Client-Hints sent with the right RW value Accept-CH header is present');

+ var t = async_test('Client-Hints sent with the right Width value Accept-CH header is present');

window.onload = t.step_func(function() {

assert_not_equals(document.getElementById("testimg1").naturalWidth, 0);

assert_not_equals(document.getElementById("testimg2").naturalWidth, 0);

assert_not_equals(document.getElementById("testimg3").naturalWidth, 0);

+ assert_not_equals(document.getElementById("testimg4").naturalWidth, 0);

t.done();

});

</script>