Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1183233002: Split RW hint into Width and Viewport-Width (Closed)

Created:
5 years, 6 months ago by Yoav Weiss
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Split RW hint into Width and Viewport-Width This CL aligns the implementation with the spec, by splitting up the RW hint into the "Width" and "Viewport-Width" hints: https://github.com/igrigorik/http-client-hints/pull/48 BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197164

Patch Set 1 #

Patch Set 2 : Fixed and added layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -80 lines) Patch
M LayoutTests/http/tests/misc/client-hints-accept.php View 1 2 chunks +10 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/misc/client-hints-accept-meta.html View 1 2 chunks +10 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/misc/client-hints-accept-meta-preloader.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/client-hints-dynamic-rw-sizes.html View 1 1 chunk +6 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/misc/client-hints-no-accept.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html View 1 1 chunk +7 lines, -5 lines 0 comments Download
D LayoutTests/http/tests/misc/resources/image-checks-for-rw.php View 1 1 chunk +0 lines, -12 lines 0 comments Download
A LayoutTests/http/tests/misc/resources/image-checks-for-viewport-width.php View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/misc/resources/image-checks-for-width.php View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ClientHintsPreferences.h View 1 chunk +12 lines, -6 lines 0 comments Download
M Source/core/fetch/ClientHintsPreferences.cpp View 1 chunk +12 lines, -8 lines 0 comments Download
M Source/core/fetch/ClientHintsPreferencesTest.cpp View 1 chunk +12 lines, -11 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +12 lines, -8 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +26 lines, -11 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Yoav Weiss
Hey Mike, Can you take a look? :)
5 years, 6 months ago (2015-06-15 21:55:42 UTC) #2
Mike West
The failing tests look quite relevant. :)
5 years, 6 months ago (2015-06-16 06:52:17 UTC) #3
Yoav Weiss
On 2015/06/16 06:52:17, Mike West wrote: > The failing tests look quite relevant. :) indeed...
5 years, 6 months ago (2015-06-16 07:03:34 UTC) #4
Yoav Weiss
On 2015/06/16 07:03:34, Yoav Weiss wrote: > On 2015/06/16 06:52:17, Mike West wrote: > > ...
5 years, 6 months ago (2015-06-16 08:40:04 UTC) #5
Mike West
LGTM, thanks!
5 years, 6 months ago (2015-06-16 09:05:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183233002/20001
5 years, 6 months ago (2015-06-16 09:08:03 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 09:12:05 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197164

Powered by Google App Engine
This is Rietveld 408576698