Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1183223004: Revert of Modify annotated_run to read factory configs from the slave checkout. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
CC:
Paweł Hajdan Jr., chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org, ghost stip (do not use)
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Modify annotated_run to read factory configs from the slave checkout. (patchset #6 id:140001 of https://codereview.chromium.org/1178733003/) Reason for revert: Reverting, probably broke things. Original issue's description: > Modify annotated_run to read factory configs from the slave checkout. > > Currently if you wish to change the recipe a builder uses, or > change the other factory properties associated with a builder, > you need to restart the master. > > This change modifies annotated_run.py so that instead of taking > the information the master hands us, we ignore it and use the > copy of the master config we find in the slave checkout, which > should be up-to-date. > > This should allow us to eliminate a decent number of master restarts. > (Though it would still be a good idea to restart the masters > periodically so that they don't get too stale). > > R=iannucci@chromium.org, phajdan.jr@chromium.org, luqui@chromium.org > BUG=499071 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295684 TBR=phajdan.jr@chromium.org,iannucci@chromium.org,luqui@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499071 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -104 lines) Patch
M scripts/slave/annotated_run.py View 4 chunks +26 lines, -92 lines 0 comments Download
M scripts/tools/run_recipe.py View 4 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
Created Revert of Modify annotated_run to read factory configs from the slave checkout.
5 years, 6 months ago (2015-06-15 21:44:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183223004/1
5 years, 6 months ago (2015-06-15 21:44:13 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 21:44:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295685

Powered by Google App Engine
This is Rietveld 408576698