Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1183223003: Don't build sky_packager on Mac hosts (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
cdotstout, cstout
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't build sky_packager on Mac hosts sky_packager requires C++11 and the Mac host toolchain can't handle C++11. R=cstout@chromium.org, cstout@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e609ae2402d7ee86fead0dde5bafc29f9bb671c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M sky/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-15 21:18:02 UTC) #1
cdotstout
lgtm
5 years, 6 months ago (2015-06-15 21:19:50 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-15 22:04:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e609ae2402d7ee86fead0dde5bafc29f9bb671c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698