Inline code generation for %_IsTypedArray

Inline code generation for %_IsTypedArray

This patch implements %_IsTypedArray in fullcodegen, Hydrogen and
Turbofan in order to implement fast type checks to enable ES6
TypedArray features and semantics efficiently.

R=adamk,titzer
LOG=Y
BUG=v8:4085
Committed: https://crrev.com/350a70e5ef4262baf912f09389f1eb1d1aa9f842
Cr-Commit-Position: refs/heads/master@{#29033}

[Dan Ehrenberg, 2015-06-15 18:00:33]

I couldn't figure out how to run the Turbofan tests. tools/run-tests.py didn't
seem to work. Any suggestions?

The current code only includes x64 support; I'll fill in the others after this
initial review.

[adamk, 2015-06-15 18:18:12]

adamk@chromium.org changed reviewers:
+ arv@chromium.org

[adamk, 2015-06-15 18:18:13]

This looks good % turbofan, please go ahead with the rest of the architectures
for full-codegen.

For TurboFan, I see that there's something in typer.cc for kInlineIsArray as
well, I think you want to add one for your thing there.

+arv for TurboFan support in this timezone.

When you say turbofan tests, do you mean the unittests? I think you should be
able to use "run-tests.py unittests" to run them.

[Dan Ehrenberg, 2015-06-15 18:58:09]

On 2015/06/15 18:18:13, adamk wrote:
> This looks good % turbofan, please go ahead with the rest of the architectures
> for full-codegen.
> 
> For TurboFan, I see that there's something in typer.cc for kInlineIsArray as
> well, I think you want to add one for your thing there.
> 
> +arv for TurboFan support in this timezone.
> 
> When you say turbofan tests, do you mean the unittests? I think you should be
> able to use "run-tests.py unittests" to run them.

OK, changed typer.cc and added support for other fullcodegen backends.
run-tests.py unittests seems to work now; not sure what was happening before.

[Michael Starzinger, 2015-06-15 19:04:51]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-06-15 19:04:52]

LGTM on the TurboFan part FWIW, didn't look at full-codegen or Crankshaft.

[Dan Ehrenberg, 2015-06-15 19:17:02]

On 2015/06/15 19:04:52, Michael Starzinger wrote:
> LGTM on the TurboFan part FWIW, didn't look at full-codegen or Crankshaft.

Thanks for the review; I'll hold off on submitting this until I get another LGTM
for those aspects.

[adamk, 2015-06-15 20:25:50]

https://codereview.chromium.org/1183213002/diff/20001/src/mips64/full-codegen...
File src/mips64/full-codegen-mips64.cc (left):

https://codereview.chromium.org/1183213002/diff/20001/src/mips64/full-codegen...
src/mips64/full-codegen-mips64.cc:3610: void
FullCodeGenerator::EmitIsArray(CallRuntime* expr) {
I think you'll need to keep EmitIsArray() and add a new EmitIsTypedArray.

[adamk, 2015-06-15 20:26:00]

adamk@chromium.org changed reviewers:
- arv@chromium.org, titzer@chromium.org

[Dan Ehrenberg, 2015-06-15 20:32:23]

https://codereview.chromium.org/1183213002/diff/20001/src/mips64/full-codegen...
File src/mips64/full-codegen-mips64.cc (left):

https://codereview.chromium.org/1183213002/diff/20001/src/mips64/full-codegen...
src/mips64/full-codegen-mips64.cc:3610: void
FullCodeGenerator::EmitIsArray(CallRuntime* expr) {
On 2015/06/15 20:25:50, adamk wrote:
> I think you'll need to keep EmitIsArray() and add a new EmitIsTypedArray.

Oops, fixed.

[adamk, 2015-06-15 20:34:02]

lgtm

Let's wait to land this until the tree recovers from the other failure.

[adamk, 2015-06-15 21:17:42]

The CQ bit was checked by adamk@chromium.org

[adamk, 2015-06-15 21:17:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1183213002/#ps40001
(title: "don't remove mips64 EmitIsArray")

[commit-bot: I haz the power, 2015-06-15 21:17:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183213002/40001

[commit-bot: I haz the power, 2015-06-15 22:16:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-15 22:16:55]

Patchset 3 (id:??) landed as
https://crrev.com/350a70e5ef4262baf912f09389f1eb1d1aa9f842
Cr-Commit-Position: refs/heads/master@{#29033}