Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1183193003:
Load visualbench pictures one at a time. (Closed)
|
Created:
5 years, 6 months ago by bsalomon Modified:
5 years, 6 months ago Reviewers:
joshualitt CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@stuff Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionLoad visualbench pictures one at a time.
Add flag to run in windowed mode.
NOPRESUBMIT=true
Committed: https://skia.googlesource.com/skia/+/45171e20b37c0bab0e46ae0ffeb8993058a36b13
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : reupload? #
Messages
Total messages: 26 (12 generated)
bsalomon@google.com changed reviewers: + joshualitt@google.com
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183193003/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-06-17 01:45 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
On 2015/06/16 19:45:40, commit-bot: I haz the power wrote: > Note for Reviewers: > The CQ is waiting for an approval. > If you believe that the CL is not ready yet, or if you would like to L-G-T-M > with comments then please uncheck the CQ checkbox. > > Waiting for LGTM from valid reviewer(s) till 2015-06-17 01:45 UTC lgtm
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from joshualitt@google.com Link to the patchset: https://codereview.chromium.org/1183193003/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183193003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183193003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from joshualitt@google.com Link to the patchset: https://codereview.chromium.org/1183193003/#ps40001 (title: "reupload?")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183193003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183193003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/45171e20b37c0bab0e46ae0ffeb8993058a36b13 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
