[DevTools] Show sync XHR info during request loading.

[DevTools] Show sync XHR info during request loading.

BUG=500219
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197175

[dgozman, 2015-06-15 14:43:54]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2015-06-15 14:43:54]

Take a look please.

[pfeldman, 2015-06-15 15:21:00]

https://codereview.chromium.org/1183173002/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorResourceAgent.h (right):

https://codereview.chromium.org/1183173002/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorResourceAgent.h:77: virtual void
flushPendingProtocolNotifications() { }
Lets make it available to the InspectorBaseAgent::requestFlush

[dgozman, 2015-06-15 15:56:12]

https://codereview.chromium.org/1183173002/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorResourceAgent.h (right):

https://codereview.chromium.org/1183173002/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorResourceAgent.h:77: virtual void
flushPendingProtocolNotifications() { }
On 2015/06/15 15:21:00, pfeldman wrote:
> Lets make it available to the InspectorBaseAgent::requestFlush

Found InspectorFrotendChannel::flush.

[dgozman, 2015-06-15 15:56:17]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-06-15 15:56:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183173002/20001

[commit-bot: I haz the power, 2015-06-15 15:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 15:56:44]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pfeldman, 2015-06-15 15:58:08]

lgtm

[dgozman, 2015-06-15 15:58:25]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-06-15 15:58:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183173002/20001

[commit-bot: I haz the power, 2015-06-15 17:35:37]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197128

[jianli, 2015-06-15 21:13:31]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1175263003/ by jianli@chromium.org.

The reason for reverting is: Caused crashes to several inspector tests:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

  http/tests/inspector/filesystem/async-callstack-filesystem.html [ Crash ]
  http/tests/inspector/filesystem/request-file-content.html [ Crash ]
  http/tests/inspector/service-workers/service-workers-view.html [ Crash ]
  http/tests/inspector/service-workers/user-agent-override.html [ Crash ]
  inspector/console/console-revoke-error-in-worker.html [ Crash ]
  inspector/console/console-uncaught-promise-in-worker.html [ Crash ]
  inspector/console/worker-eval-contains-stack.html [ Crash ]
  inspector/console/worker-exception-message-contains-stack.html [ Crash ]
  inspector/file-reader-with-network-panel.html [ Crash ]
  inspector/sources/debugger-ui/script-snippet-model.html [ Crash ]

==4==WARNING: MemorySanitizer: use-of-uninitialized-value
      #0 0x7fed2e08e7c3 in
blink::InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient(unsigned
long, blink::ThreadableLoaderClient*)
third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp:496:9
      #1 0x7fed2e1aabae in documentThreadableLoaderStartedLoadingForClient
/b/build/slave/WebKit_Linux_MSAN/build/src/out/Release/gen/blink/core/InspectorInstrumentationInl.h:598:9
      #2 0x7fed2e1aabae in
blink::DocumentThreadableLoader::loadRequest(blink::ResourceRequest const&,
blink::ResourceLoaderOptions)
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:593:0
.

[dgozman, 2015-06-16 13:45:22]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-06-16 13:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1183173002/#ps40001
(title: "Initialized m_pendingXHR")

[commit-bot: I haz the power, 2015-06-16 13:45:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183173002/40001

[commit-bot: I haz the power, 2015-06-16 15:46:08]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197175