Issue 1183143012: Widgets should be stateful before calling setState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1183143012: Widgets should be stateful before calling setState (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	sky/sdk/lib/widgets/button_base.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/sdk/lib/widgets/widget.dart	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jackson

5 years, 6 months ago (2015-06-18 23:36:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8bbc3a1d27d593f157939f088d5fdd96f64f8e65 (presubmit successful).