Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1183143002: [DevTools] Fixed blink of "No Event Listeners" in event listeners sidebar (Closed)

Created:
4 years, 10 months ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Fixed blink of "No Event Listeners" in event listeners sidebar BUG=499703 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197263

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/EventListenersView.js View 1 2 3 chunks +32 lines, -9 lines 2 comments Download
M Source/devtools/front_end/elements/EventListenersWidget.js View 1 1 chunk +6 lines, -26 lines 2 comments Download
M Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 12 (2 generated)
kozy
4 years, 10 months ago (2015-06-15 10:52:58 UTC) #1
pfeldman
https://codereview.chromium.org/1183143002/diff/1/Source/devtools/front_end/elements/EventListenersWidget.js File Source/devtools/front_end/elements/EventListenersWidget.js (right): https://codereview.chromium.org/1183143002/diff/1/Source/devtools/front_end/elements/EventListenersWidget.js#newcode73 Source/devtools/front_end/elements/EventListenersWidget.js:73: this._eventListenersView.reset(); You should not reset the view until you ...
4 years, 10 months ago (2015-06-15 15:55:19 UTC) #2
kozy
Pavel, please take a look.
4 years, 10 months ago (2015-06-16 10:03:46 UTC) #3
pfeldman
https://codereview.chromium.org/1183143002/diff/20001/Source/devtools/front_end/components/EventListenersView.js File Source/devtools/front_end/components/EventListenersView.js (right): https://codereview.chromium.org/1183143002/diff/20001/Source/devtools/front_end/components/EventListenersView.js#newcode40 Source/devtools/front_end/components/EventListenersView.js:40: function listenerPromise(object) { { goes next line, annotate. https://codereview.chromium.org/1183143002/diff/20001/Source/devtools/front_end/components/EventListenersView.js#newcode41 ...
4 years, 10 months ago (2015-06-16 18:39:46 UTC) #4
kozy
All done. please take a look.
4 years, 10 months ago (2015-06-17 12:12:12 UTC) #5
pfeldman
lgtm
4 years, 10 months ago (2015-06-17 12:23:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183143002/40001
4 years, 10 months ago (2015-06-17 12:25:39 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197263
4 years, 10 months ago (2015-06-17 14:27:59 UTC) #9
lushnikov
https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_end/components/EventListenersView.js File Source/devtools/front_end/components/EventListenersView.js (right): https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_end/components/EventListenersView.js#newcode54 Source/devtools/front_end/components/EventListenersView.js:54: addObjectEventListeners: function(object, eventListeners) private? https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_end/elements/EventListenersWidget.js File Source/devtools/front_end/elements/EventListenersWidget.js (right): https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_end/elements/EventListenersWidget.js#newcode75 ...
4 years, 10 months ago (2015-06-17 14:44:50 UTC) #11
kozy
4 years, 10 months ago (2015-06-17 15:54:32 UTC) #12
Message was sent while issue was closed. 
All done in https://codereview.chromium.org/1187303002/

https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_e...
File Source/devtools/front_end/components/EventListenersView.js (right):

https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/components/EventListenersView.js:54:
addObjectEventListeners: function(object, eventListeners)
On 2015/06/17 14:44:50, lushnikov wrote:
> private?

Done.

https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_e...
File Source/devtools/front_end/elements/EventListenersWidget.js (right):

https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/EventListenersWidget.js:75:
this._eventListenersView.reset();
On 2015/06/17 14:44:50, lushnikov wrote:
> addEmptyHolderIfNeeded

Done.

https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_e...
File Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js
(right):

https://codereview.chromium.org/1183143002/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js:33:
this._eventListenersView.reset();
On 2015/06/17 14:44:50, lushnikov wrote:
> addEmptyHolderIfNeeded

Done.

Powered by Google App Engine
This is Rietveld 408576698