Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1183053005: Switch to glyphs as paths at a higher point size on Android (Closed)

Created:
5 years, 6 months ago by jvanverth1
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch to glyphs as paths at a higher point size on Android The regression occurred when we dropped the maximum DF size from 192 to 162, which meant that any glyph > 324 ended up being rendered as paths rather than the previous > 384. This pushes the threshold for rendering paths up to 384. Quality looks fine on high-res devices which is why this is restricted to Android-only (low-res Android devices should only rarely have text that large). BUG=chromium:467569 Committed: https://skia.googlesource.com/skia/+/932d413e69845989fadaecf5bcb8686ec8c05032 Committed: https://skia.googlesource.com/skia/+/97c595f304567abac00dbe4fa6ea9b4d8bf5d89f

Patch Set 1 #

Patch Set 2 : Tweak large glyph limit to fix mixedtextblob GM #

Patch Set 3 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/gpu/GrAtlasTextContext.cpp View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
jvanverth1
5 years, 6 months ago (2015-06-18 19:41:13 UTC) #2
joshualitt
On 2015/06/18 19:41:13, jvanverth1 wrote: LGTM
5 years, 6 months ago (2015-06-18 20:29:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183053005/1
5 years, 6 months ago (2015-06-18 20:31:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/932d413e69845989fadaecf5bcb8686ec8c05032
5 years, 6 months ago (2015-06-18 20:46:49 UTC) #6
f(malita)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1192203002/ by fmalita@chromium.org. ...
5 years, 6 months ago (2015-06-18 21:34:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183053005/20001
5 years, 6 months ago (2015-06-19 17:51:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/589)
5 years, 6 months ago (2015-06-19 17:52:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183053005/40001
5 years, 6 months ago (2015-06-19 17:59:35 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 18:06:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/97c595f304567abac00dbe4fa6ea9b4d8bf5d89f

Powered by Google App Engine
This is Rietveld 408576698