Issue 1183033004: js_ast: implement rest/spread parsing

Issue 1183033004: js_ast: implement rest/spread parsing (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly

Modified:
5 years, 6 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -53 lines)			Patch
M	lib/runtime/_operations.js	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	lib/runtime/dart/_js_mirrors.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/runtime/dart_runtime.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/src/js/builder.dart	View		9 chunks	+71 lines, -27 lines	0 comments	Download
M	lib/src/js/nodes.dart	View	1	9 chunks	+38 lines, -6 lines	0 comments	Download
M	lib/src/js/precedence.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/src/js/printer.dart	View	1	7 chunks	+16 lines, -7 lines	0 comments	Download
M	lib/src/js/template.dart	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	tool/input_sdk/private/js_mirrors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tool/sdk_expected_errors.txt	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

Jennifer Messerly

I wasn't able to actually use rest parameters yet (they'd work for redirectingConstructor) ... but ...

5 years, 6 months ago (2015-06-16 21:03:01 UTC) #2

Jennifer Messerly

On 2015/06/16 21:03:01, John Messerly wrote: > I wasn't able to actually use rest parameters ...

5 years, 6 months ago (2015-06-16 21:03:26 UTC) #3

Jennifer Messerly

5 years, 6 months ago (2015-06-16 23:10:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
94f8e6421ab787f2fd8c104d57954156d8ed2aae (presubmit successful).