Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 118303002: Harmony: implement math.hypot. (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Harmony: implement math.hypot. R=jarin@chromium.org BUG=v8:2938 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=18407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1 line) Patch
M src/harmony-math.js View 2 chunks +35 lines, -1 line 0 comments Download
A test/mjsunit/harmony/math-hypot.js View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
7 years ago (2013-12-18 15:00:47 UTC) #1
Jakob Kummerow
DBC: LOG=N, features behind flags don't deserve being mentioned in the ChangeLog.
7 years ago (2013-12-18 15:33:12 UTC) #2
Yang
On 2013/12/18 15:33:12, Jakob wrote: > DBC: LOG=N, features behind flags don't deserve being mentioned ...
7 years ago (2013-12-18 17:24:00 UTC) #3
Yang
On 2013/12/18 17:24:00, Yang wrote: > On 2013/12/18 15:33:12, Jakob wrote: > > DBC: LOG=N, ...
7 years ago (2013-12-23 10:00:44 UTC) #4
Jarin
lgtm
7 years ago (2013-12-23 10:28:42 UTC) #5
Yang
7 years ago (2013-12-23 11:13:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r18407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698