Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(30)

Issue 1183023003: Move (copy/remove)BlockProperties out of MutableStylePropertySet (Closed)

Created:
4 years, 10 months ago by Timothy Loh
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move (copy/remove)BlockProperties out of MutableStylePropertySet This patch moves the copyBlockProperties and removeBlockProperties methods out of MutableStylePropertySet and inlines them into the editing code which uses them. It seems strange that MutableStylePropertySet would need to know about which properties only affect block-level elements. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197227

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -48 lines) Patch
M Source/core/css/StylePropertySet.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 2 chunks +34 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
4 years, 10 months ago (2015-06-15 04:20:42 UTC) #2
rune
lgtm https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/EditingStyle.cpp File Source/core/editing/EditingStyle.cpp (right): https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/EditingStyle.cpp#newcode659 Source/core/editing/EditingStyle.cpp:659: m_mutableStyle->removePropertiesInSet(blockPropertiesVector().data(), blockPropertiesVector().size()); I thought removePropertiesFromSet sounded better. Likewise, ...
4 years, 10 months ago (2015-06-16 06:46:59 UTC) #4
Timothy Loh
https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/EditingStyle.cpp File Source/core/editing/EditingStyle.cpp (right): https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/EditingStyle.cpp#newcode659 Source/core/editing/EditingStyle.cpp:659: m_mutableStyle->removePropertiesInSet(blockPropertiesVector().data(), blockPropertiesVector().size()); On 2015/06/16 06:46:59, rune wrote: > I ...
4 years, 10 months ago (2015-06-17 01:31:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183023003/1
4 years, 10 months ago (2015-06-17 01:32:58 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 02:38:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197227

Powered by Google App Engine
This is Rietveld 408576698