Move (copy/remove)BlockProperties out of MutableStylePropertySet

Move (copy/remove)BlockProperties out of MutableStylePropertySet

This patch moves the copyBlockProperties and removeBlockProperties
methods out of MutableStylePropertySet and inlines them into the editing
code which uses them. It seems strange that MutableStylePropertySet
would need to know about which properties only affect block-level
elements.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197227

[Timothy Loh, 2015-06-15 04:20:42]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org

[rune, 2015-06-16 06:46:59]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2015-06-16 06:46:59]

lgtm

https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingStyle.cpp:659:
m_mutableStyle->removePropertiesInSet(blockPropertiesVector().data(),
blockPropertiesVector().size());
I thought removePropertiesFromSet sounded better. Likewise,
copyPropertiesFromSet. But then I realized you might be referring to
blockPropertiesVector() as the "set"?

[Timothy Loh, 2015-06-17 01:31:43]

https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/1183023003/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingStyle.cpp:659:
m_mutableStyle->removePropertiesInSet(blockPropertiesVector().data(),
blockPropertiesVector().size());
On 2015/06/16 06:46:59, rune wrote:
> I thought removePropertiesFromSet sounded better. Likewise,
> copyPropertiesFromSet. But then I realized you might be referring to
> blockPropertiesVector() as the "set"?

I didn't really look at the names since I was just moving out a couple of
functions, but yeah removePropertiesFromSet might be misleading here.

[Timothy Loh, 2015-06-17 01:31:47]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2015-06-17 01:32:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183023003/1

[commit-bot: I haz the power, 2015-06-17 02:38:49]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197227