Shallow flush after calling beginSetPixels

cc/tile_manager.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/tile_manager.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
@@ skipping 531 matching lines @@
     // different than texture format.
     managed_tile_state.contents_swizzled =
         !PlatformColor::sameComponentOrder(tile->format_);
 
     // Tile resources can't be freed until upload has completed.
     managed_tile_state.can_be_freed = false;
 
     resource_pool_->resource_provider()->beginSetPixels(resource->id());
     managed_tile_state.resource = resource.Pass();
     tiles_with_pending_set_pixels_.push(tile);
+
+    resource_pool_->resource_provider()->shallowFlushIfSupported();

[epenner, 2013/01/10 04:45:49]

Could this just go straight into the resource provider?

In general I'm starting to think the upload query and flushes should come out of
the resource provider so we could do things in batches rather than do everything
per-upload (query / flush / etc.)  But maybe the overhead is negligible? It
looks significant on traces, but maybe that's just tracing overhead?

[reveman, 2013/01/10 14:46:58]

I think the tile manager is the right place for this. Batches might be the way
to go but I think that should be controlled by the tile manager rather than
being hidden behind the resource provider interface.

[epenner, 2013/01/10 17:34:42]

Yeah sorry, this patch is good as is, just thinking out loud on the batching.

But could shallowFlush call not just go in beginSetPixels for now?  Seems like
we could benefit on any beginSetPixels call.

[epenner, 2013/01/10 17:45:42]

So actually I talked with Dave and this is good as is. The flush can later be
used to kick off batches of uploads, which means it should stay outside of
resource provider.

   } else {
     resource_pool_->resource_provider()->releasePixelBuffer(resource->id());
     resource_pool_->ReleaseResource(resource.Pass());
     managed_tile_state.resource_is_being_initialized = false;
   }
 
   DispatchMoreTasks();
 }
 
 void TileManager::DidFinishTileInitialization(Tile* tile) {
   ManagedTileState& managed_tile_state = tile->managed_state();
   DCHECK(managed_tile_state.resource);
   managed_tile_state.resource_is_being_initialized = false;
   managed_tile_state.can_be_freed = true;
   for (int i = 0; i < NUM_TREES; ++i)
     drawable_tiles_in_bin_count_[managed_tile_state.bin[i]][i]++;
 }
 
 }  // namespace cc