cc/scheduler_state_machine.cc - Issue 11830040: cc: Do not request redraw on commit when impl-side painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler_state_machine.cc

Issue 11830040: cc: Do not request redraw on commit when impl-side painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_draw3

Patch Set: Keep needsRedraw decision in the commit state Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler_state_machine.cc

diff --git a/cc/scheduler_state_machine.cc b/cc/scheduler_state_machine.cc

index 31df0bc86e87c9850208cd4c081b3dad3ee234e1..dc7a16581356d9f80c7929f42c11f217f24763f9 100644

--- a/cc/scheduler_state_machine.cc

+++ b/cc/scheduler_state_machine.cc

@@ -9,8 +9,9 @@

namespace cc {

-SchedulerStateMachine::SchedulerStateMachine()

- : m_commitState(COMMIT_STATE_IDLE)

+SchedulerStateMachine::SchedulerStateMachine(bool implSidePaintingEnabled)

+ : m_implSidePaintingEnabled(implSidePaintingEnabled)

nduca 2013/01/11 04:07:31 this makes sense to stay as a bool...

brianderson 2013/01/12 00:38:34 I'm just going to pass it all the way down, just i

+ , m_commitState(COMMIT_STATE_IDLE)

, m_currentFrameNumber(0)

, m_lastFrameNumberWhereDrawWasCalled(-1)

, m_lastFrameNumberWhereTreeActivationAttempted(-1)

@@ -198,7 +199,8 @@ void SchedulerStateMachine::updateState(Action action)

m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_FORCED_DRAW;

else

m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_DRAW;

- m_needsRedraw = true;

+ if (!m_implSidePaintingEnabled)

+ m_needsRedraw = true;

if (m_drawIfPossibleFailed)

m_lastFrameNumberWhereDrawWasCalled = -1;

« cc/scheduler.h ('K') | « cc/scheduler_state_machine.h ('k') | cc/thread_proxy.cc » ('j') | no next file with comments »