Make all net targets build on Win64

net/net.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
 
     'linux_link_kerberos%': 0,
     'conditions': [
@@ skipping 1149 matching lines @@
               'socket/tcp_server_socket_libevent.h',
               'udp/udp_socket_libevent.cc',
               'udp/udp_socket_libevent.h',
             ],
             'dependencies': [
               '../third_party/nss/nss.gyp:nspr',
               '../third_party/nss/nss.gyp:nss',
               'third_party/nss/ssl.gyp:libssl',
               'tld_cleanup',
             ],
+            # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+            'msvs_disabled_warnings': [4267, ],

[cbentzel, 2013/01/10 17:31:03]

Can you provide a list of lines where compiler failed with this warning?

[jschuh, 2013/01/10 17:39:42]

Not practically speaking, because it's a massive list. Sadly, the Google C++
style guide encourages a pattern that's hostile to proper use of size_t and
ptrdiff_t, so we have a slew of these compilation warnings (and simply ignore
them on other 64-bit platforms).

           }, { # else: OS != "win"
             'sources!': [
               'base/winsock_init.cc',
               'base/winsock_init.h',
               'base/winsock_util.cc',
               'base/winsock_util.h',
               'proxy/proxy_resolver_winhttp.cc',
               'proxy/proxy_resolver_winhttp.h',
             ],
           },
@@ skipping 502 matching lines @@
               'http/http_auth_gssapi_posix_unittest.cc',
             ],
             # This is needed to trigger the dll copy step on windows.
             # TODO(mark): Specifying this here shouldn't be necessary.
             'dependencies': [
               '../third_party/icu/icu.gyp:icudata',
               '../third_party/nss/nss.gyp:nspr',
               '../third_party/nss/nss.gyp:nss',
               'third_party/nss/ssl.gyp:libssl',
             ],
+            # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+            'msvs_disabled_warnings': [4267, ],
           },
         ],
         [ 'OS == "mac"', {
             'dependencies': [
               '../third_party/nss/nss.gyp:nspr',
               '../third_party/nss/nss.gyp:nss',
               'third_party/nss/ssl.gyp:libssl',
             ],
           },
         ],
@@ skipping 112 matching lines @@
               'proxy/proxy_resolver_perftest.cc',
             ],
           },
         ],
         # This is needed to trigger the dll copy step on windows.
         # TODO(mark): Specifying this here shouldn't be necessary.
         [ 'OS == "win"', {
             'dependencies': [
               '../third_party/icu/icu.gyp:icudata',
             ],
+            # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+            'msvs_disabled_warnings': [4267, ],
           },
         ],
       ],
     },
     {
       'target_name': 'net_test_support',
       'type': 'static_library',
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:test_support_base',
@@ skipping 111 matching lines @@
             '../third_party/nss/nss.gyp:nss',
           ],
         }],
         [ 'use_v8_in_net==1', {
             'dependencies': [
               'net_with_v8',
             ],
           },
         ],
       ],
+      # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+      'msvs_disabled_warnings': [4267, ],
     },
     {
       'target_name': 'net_resources',
       'type': 'none',
       'variables': {
         'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/net',
       },
       'actions': [
         {
           'action_name': 'net_resources',
@@ skipping 16 matching lines @@
       'sources': [
         'server/http_connection.cc',
         'server/http_connection.h',
         'server/http_server.cc',
         'server/http_server.h',
         'server/http_server_request_info.cc',
         'server/http_server_request_info.h',
         'server/web_socket.cc',
         'server/web_socket.h',
       ],
+      # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+      'msvs_disabled_warnings': [4267, ],
     },
     {
       'target_name': 'dump_cache',
       'type': 'executable',
       'dependencies': [
         '../base/base.gyp:base',
         'net',
         'net_test_support',
       ],
       'sources': [
         'tools/dump_cache/cache_dumper.cc',
         'tools/dump_cache/cache_dumper.h',
         'tools/dump_cache/dump_cache.cc',
         'tools/dump_cache/dump_files.cc',
         'tools/dump_cache/dump_files.h',
         'tools/dump_cache/simple_cache_dumper.cc',
         'tools/dump_cache/simple_cache_dumper.h',
         'tools/dump_cache/upgrade_win.cc',
         'tools/dump_cache/upgrade_win.h',
         'tools/dump_cache/url_to_filename_encoder.cc',
         'tools/dump_cache/url_to_filename_encoder.h',
         'tools/dump_cache/url_utilities.h',
         'tools/dump_cache/url_utilities.cc',
       ],
+      # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+      'msvs_disabled_warnings': [4267, ],
     },
   ],
   'conditions': [
     ['use_v8_in_net == 1', {
       'targets': [
         {
           'target_name': 'net_with_v8',
           'type': '<(component)',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'dependencies': [
             '../base/base.gyp:base',
             '../build/temp_gyp/googleurl.gyp:googleurl',
             '../v8/tools/gyp/v8.gyp:v8',
             'net'
           ],
           'defines': [
             'NET_IMPLEMENTATION',
           ],
           'sources': [
             'proxy/proxy_resolver_v8.cc',
             'proxy/proxy_resolver_v8.h',
             'proxy/proxy_service_v8.cc',
             'proxy/proxy_service_v8.h',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
       ],
     }],
     ['OS != "ios"', {
       'targets': [
         # iOS doesn't have the concept of simple executables, these targets
         # can't be compiled on the platform.
         {
           'target_name': 'crash_cache',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             'net',
             'net_test_support',
           ],
           'sources': [
             'tools/crash_cache/crash_cache.cc',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
         {
           'target_name': 'crl_set_dump',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             'net',
           ],
           'sources': [
             'tools/crl_set_dump/crl_set_dump.cc',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
         {
           'target_name': 'dns_fuzz_stub',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             'net',
           ],
           'sources': [
             'tools/dns_fuzz_stub/dns_fuzz_stub.cc',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
         {
           'target_name': 'fetch_client',
           'type': 'executable',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'dependencies': [
             '../base/base.gyp:base',
             '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
             '../build/temp_gyp/googleurl.gyp:googleurl',
             '../testing/gtest.gyp:gtest',
             'net',
             'net_with_v8',
           ],
           'sources': [
             'tools/fetch/fetch_client.cc',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
         {
           'target_name': 'fetch_server',
           'type': 'executable',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'dependencies': [
             '../base/base.gyp:base',
             '../build/temp_gyp/googleurl.gyp:googleurl',
             'net',
           ],
           'sources': [
             'tools/fetch/fetch_server.cc',
             'tools/fetch/http_listen_socket.cc',
             'tools/fetch/http_listen_socket.h',
             'tools/fetch/http_server.cc',
             'tools/fetch/http_server.h',
             'tools/fetch/http_server_request_info.cc',
             'tools/fetch/http_server_request_info.h',
             'tools/fetch/http_server_response_info.cc',
             'tools/fetch/http_server_response_info.h',
             'tools/fetch/http_session.cc',
             'tools/fetch/http_session.h',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
         {
           'target_name': 'gdig',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             'net',
           ],
           'sources': [
             'tools/gdig/file_net_log.cc',
             'tools/gdig/gdig.cc',
           ],
         },
         {
           'target_name': 'get_server_time',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             '../base/base.gyp:base_i18n',
             '../build/temp_gyp/googleurl.gyp:googleurl',
             'net',
           ],
           'sources': [
             'tools/get_server_time/get_server_time.cc',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
         {
           'target_name': 'net_watcher',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             'net',
             'net_with_v8',
           ],
           'conditions': [
@@ skipping 27 matching lines @@
           'target_name': 'stress_cache',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             'net',
             'net_test_support',
           ],
           'sources': [
             'disk_cache/stress_cache.cc',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
         {
           'target_name': 'tld_cleanup',
           'type': 'executable',
           'dependencies': [
             '../base/base.gyp:base',
             '../base/base.gyp:base_i18n',
             '../build/temp_gyp/googleurl.gyp:googleurl',
           ],
           'sources': [
             'tools/tld_cleanup/tld_cleanup.cc',
           ],
+          # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+          'msvs_disabled_warnings': [4267, ],
         },
       ],
     }],
     ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', {
       'targets': [
         {
           'target_name': 'flip_in_mem_edsm_server',
           'type': 'executable',
           'cflags': [
             '-Wno-deprecated',
@@ skipping 188 matching lines @@
                 '--result', '<@(_outputs)',
                 '--isolate', 'net_unittests.isolate',
               ],
             },
           ],
         },
       ],
     }],
   ],
 }